Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(storage): support UniverseDomainOption for REST #13471

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

dbolduc
Copy link
Member

@dbolduc dbolduc commented Jan 18, 2024

Fixes #13345


This change is Reviewable

@product-auto-label product-auto-label bot added the api: storage Issues related to the Cloud Storage API. label Jan 18, 2024
@dbolduc dbolduc marked this pull request as ready for review January 18, 2024 19:16
@dbolduc dbolduc requested a review from a team as a code owner January 18, 2024 19:16
Copy link

codecov bot commented Jan 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f471fd4) 93.10% compared to head (1c2b361) 93.10%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13471      +/-   ##
==========================================
- Coverage   93.10%   93.10%   -0.01%     
==========================================
  Files        2183     2183              
  Lines      190025   190046      +21     
==========================================
+ Hits       176924   176943      +19     
- Misses      13101    13103       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dbolduc dbolduc merged commit b1a3972 into googleapis:main Jan 18, 2024
60 checks passed
@dbolduc dbolduc deleted the storage-ud-pr-2 branch January 18, 2024 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the Cloud Storage API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Universe Domain support for storage (REST)
2 participants