Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(spanner): add spanner::Value support for ProtoEnum/ProtoMessage #13747

Merged
merged 1 commit into from Mar 8, 2024

Conversation

devbww
Copy link
Collaborator

@devbww devbww commented Mar 8, 2024

This change is Reviewable

@product-auto-label product-auto-label bot added the api: spanner Issues related to the Spanner API. label Mar 8, 2024
Copy link

codecov bot commented Mar 8, 2024

Codecov Report

Attention: Patch coverage is 97.19101% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 93.25%. Comparing base (c7c14df) to head (1a358db).

Files Patch % Lines
google/cloud/spanner/value.h 95.55% 2 Missing ⚠️
google/cloud/spanner/value_test.cc 98.14% 2 Missing ⚠️
google/cloud/spanner/value.cc 96.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##             main   #13747    +/-   ##
========================================
  Coverage   93.25%   93.25%            
========================================
  Files        2233     2233            
  Lines      193152   193338   +186     
========================================
+ Hits       180127   180301   +174     
- Misses      13025    13037    +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@devbww devbww marked this pull request as ready for review March 8, 2024 03:58
@devbww devbww requested a review from a team as a code owner March 8, 2024 03:58
@devbww devbww merged commit 6b44994 into googleapis:main Mar 8, 2024
62 checks passed
@devbww devbww deleted the proto-column-values branch March 8, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the Spanner API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants