feat(spanner): add integration tests for proto columns #13756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #13756 +/- ##
==========================================
- Coverage 93.25% 93.23% -0.03%
==========================================
Files 2233 2233
Lines 193348 193413 +65
==========================================
+ Hits 180313 180325 +12
- Misses 13035 13088 +53 ☔ View full report in Codecov by Sentry. |
coryan
approved these changes
Mar 9, 2024
| if (UsingEmulator()) GTEST_SKIP() << "emulator does not support PROTO"; | ||
|
|
||
| std::vector<ProtoEnum<testing::Genre>> const data = { | ||
| testing::Genre::POP, |
There was a problem hiding this comment.
Oh noes... An enum? 😝
Where is PROGRESSIVE_JAZZ, and BEPOP, and ITALIAN_BARROQUE? And let's hope there are no macros called ROCK in any OS we need to support.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is