fix(storage): preserve full Status in default creds #13897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We no longer encourage using `google::cloud::storage::oauth2::GoogleDefaultCredentials()`, but in this case the function was dropping details about an error condition that are probably useful.
product-auto-label
bot
added
the
api: storage
devbww
approved these changes
Mar 29, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13897 +/- ##
==========================================
- Coverage 93.65% 93.05% -0.61%
==========================================
Files 2268 2181 -87
Lines 195909 185575 -10334
==========================================
- Hits 183483 172685 -10798
- Misses 12426 12890 +464 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We no longer encourage using
google::cloud::storage::oauth2::GoogleDefaultCredentials(), but in this case the function was dropping details about an error condition that are probably useful.Related to #13746
This change is