Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup: refactor SetMetadata() for gRPC-based libs #13935

Merged
merged 6 commits into from
Apr 6, 2024

Conversation

coryan
Copy link
Member

@coryan coryan commented Apr 5, 2024

Motivated by #13929 and #13928


This change is Reviewable

@coryan coryan changed the title Impl common grpc set metadata cleanup: refactor SetMetadata() for gRPC-based libs Apr 5, 2024
@coryan coryan marked this pull request as ready for review April 5, 2024 22:40
@coryan coryan requested review from a team as code owners April 5, 2024 22:40
Copy link

codecov bot commented Apr 6, 2024

Codecov Report

Attention: Patch coverage is 96.96970% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 93.12%. Comparing base (a2ecba5) to head (8a8b146).

Files Patch % Lines
...olden/v1/internal/request_id_metadata_decorator.cc 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13935      +/-   ##
==========================================
- Coverage   93.70%   93.12%   -0.59%     
==========================================
  Files        2268     2181      -87     
  Lines      196167   185840   -10327     
==========================================
- Hits       183825   173069   -10756     
- Misses      12342    12771     +429     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coryan coryan merged commit 18f522e into googleapis:main Apr 6, 2024
62 checks passed
@coryan coryan deleted the impl-common-grpc-set-metadata branch April 6, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants