Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup(storage): use Status factory functions #14143

Merged

Conversation

coryan
Copy link
Member

@coryan coryan commented May 7, 2024

Part of the work for #14107

This change is Reviewable

@product-auto-label product-auto-label bot added the api: storage Issues related to the Cloud Storage API. label May 7, 2024
@coryan coryan marked this pull request as ready for review May 7, 2024 13:14
@coryan coryan requested review from a team as code owners May 7, 2024 13:14
Copy link

codecov bot commented May 7, 2024

Codecov Report

Attention: Patch coverage is 84.29003% with 52 lines in your changes are missing coverage. Please review.

Project coverage is 93.25%. Comparing base (37f9141) to head (06d4cc2).

Files Patch % Lines
google/cloud/storage/client.cc 9.67% 28 Missing ⚠️
google/cloud/storage/parallel_upload.cc 86.44% 8 Missing ⚠️
google/cloud/storage/benchmarks/benchmark_utils.cc 66.66% 2 Missing ⚠️
.../cloud/storage/benchmarks/throughput_experiment.cc 0.00% 2 Missing ⚠️
...d/storage/internal/async/accumulate_read_object.cc 71.42% 2 Missing ⚠️
...e/cloud/storage/internal/bucket_metadata_parser.cc 66.66% 2 Missing ⚠️
google/cloud/storage/internal/object_requests.cc 81.81% 2 Missing ⚠️
google/cloud/storage/internal/rest/stub.cc 0.00% 2 Missing ⚠️
...cloud/storage/internal/retry_object_read_source.cc 66.66% 2 Missing ⚠️
.../benchmarks/aggregate_upload_throughput_options.cc 90.90% 1 Missing ⚠️
... and 1 more
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #14143   +/-   ##
=======================================
  Coverage   93.25%   93.25%           
=======================================
  Files        2205     2205           
  Lines      189168   189232   +64     
=======================================
+ Hits       176406   176468   +62     
- Misses      12762    12764    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

};

auto stream = ReadObjectImpl(request);
if (stream.bad()) {
return report_error(__func__, "cannot open download source object",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(just pointing out that) there is no longer a msg

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I decided to just pass the error without adding decoration to it.

@coryan coryan merged commit f28d70b into googleapis:main May 7, 2024
63 checks passed
@coryan coryan deleted the cleanup-storage-use-status-factory-functions branch May 7, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the Cloud Storage API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants