Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: bazel gapics s* #14186

Merged
merged 1 commit into from
May 9, 2024
Merged

Conversation

dbolduc
Copy link
Member

@dbolduc dbolduc commented May 9, 2024

Part of the work for #14171

I used a vim recording to produce these changes. It grabs the name of the library, the service_dirs, and any deps listed after grpc_utils. It makes assumptions about the contents of the BUILD.bazel file. Any nuance in the BUILD.bazel file, would get deleted.

We have to look at the contents of every BUILD.bazel file to make sure they are without nuance. That is why I am batching these PRs in sets of ~10-15. Hopefully that is not too obnoxious.


This change is Reviewable

Copy link

codecov bot commented May 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.24%. Comparing base (e3c1e5c) to head (759a95c).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14186      +/-   ##
==========================================
- Coverage   93.24%   93.24%   -0.01%     
==========================================
  Files        2206     2206              
  Lines      192119   192119              
==========================================
- Hits       179142   179139       -3     
- Misses      12977    12980       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dbolduc dbolduc marked this pull request as ready for review May 9, 2024 16:13
@dbolduc dbolduc requested review from a team as code owners May 9, 2024 16:13
@dbolduc dbolduc merged commit 75c8e77 into googleapis:main May 9, 2024
62 checks passed
@dbolduc dbolduc deleted the gapic-bazel-refactor-s branch May 9, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants