Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup(storage): prepare for clang 18 #14211

Merged
merged 1 commit into from
May 10, 2024
Merged

Conversation

alevenberg
Copy link
Member

@alevenberg alevenberg commented May 9, 2024

#14076

Step #2: /workspace/google/cloud/storage/internal/async/writer_connection_buffered.cc:164:5: error: redundant explicit casting to the same type 'void' as the sub-expression, remove this casting [readability-redundant-casting,-warnings-as-errors]
Step #2:   164 |     (void)StartWriting(std::move(lk));
Step #2:       |     ^~~~~~
Step #2: /workspace/google/cloud/storage/internal/async/writer_connection_buffered.cc:168:8: note: source type originates from the invocation of this method
Step #2:   168 |   void StartWriting(std::unique_lock<std::mutex> lk) {
Step #2:       |   ~~~~ ^
Step #2: 53615 warnings generated.

This change is Reviewable

@product-auto-label product-auto-label bot added the api: storage Issues related to the Cloud Storage API. label May 9, 2024
Copy link

codecov bot commented May 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.23%. Comparing base (2808049) to head (071340e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14211      +/-   ##
==========================================
- Coverage   93.78%   93.23%   -0.56%     
==========================================
  Files        2293     2206      -87     
  Lines      202921   192151   -10770     
==========================================
- Hits       190313   179155   -11158     
- Misses      12608    12996     +388     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alevenberg alevenberg marked this pull request as ready for review May 10, 2024 13:43
@alevenberg alevenberg requested review from a team as code owners May 10, 2024 13:43
@alevenberg alevenberg merged commit bd6390c into googleapis:main May 10, 2024
63 checks passed
@alevenberg alevenberg deleted the clang branch May 10, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the Cloud Storage API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants