Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup(pubsub): use client originated error in samples #14280

Merged
merged 3 commits into from
May 29, 2024

Conversation

alevenberg
Copy link
Member

@alevenberg alevenberg commented May 23, 2024

This change is Reviewable

@product-auto-label product-auto-label bot added api: pubsub Issues related to the Pub/Sub API. samples Issues that are directly related to samples. labels May 23, 2024
Copy link

codecov bot commented May 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.10%. Comparing base (7d7ff41) to head (3391456).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14280      +/-   ##
==========================================
- Coverage   92.97%   92.10%   -0.88%     
==========================================
  Files        2045     1693     -352     
  Lines      175012   143951   -31061     
==========================================
- Hits       162726   132586   -30140     
+ Misses      12286    11365     -921     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alevenberg alevenberg marked this pull request as ready for review May 29, 2024 15:28
@alevenberg alevenberg requested a review from a team as a code owner May 29, 2024 15:28
@alevenberg alevenberg enabled auto-merge (squash) May 29, 2024 17:02
@alevenberg alevenberg merged commit f5961a4 into googleapis:main May 29, 2024
63 checks passed
@alevenberg alevenberg deleted the pubsub23 branch May 29, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the Pub/Sub API. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants