-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update grpc and io_opencensus_cpp #2131
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2131 +/- ##
=======================================
Coverage 92.87% 92.87%
=======================================
Files 300 300
Lines 17696 17696
=======================================
Hits 16435 16435
Misses 1261 1261 Continue to review full report at Codecov.
|
I am sad about using SHAs for the dependencies. Can we wait until gRPC and protobuf release a compatible version? Or can we just update the protobuf version and override the gRPC preference? |
There should be a new release of grpc that works as soon as grpc/grpc#18080 is resolved. And open census had the v0.3.0 release on Jan 31 (https://github.com/census-instrumentation/opencensus-cpp/releases). Would that released version work for us so we don't need to depend on a commit hash? |
There is a PR to backport the fix to 1.19.x: grpc/grpc#18202 And the opencensus release should work because it refers to the new file location. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should wait until gRPC makes a new release with the fix you mentioned above. Thanks for you patience with this.
Reviewable status: 0 of 2 files reviewed, all discussions resolved (waiting on @coryan and @devjgm)
See grpc/grpc#18080
Pinging @devjgm
The problem as mentioned in the above issue is that abseil moved the location of a file. As a result, the version of io_opencensus_cpp we are using breaks. We need to update it too.
This PR doesn't update protobuf per #2090 yet, because I'm not entirely sure if we need to.
This change is![Reviewable](https://camo.githubusercontent.com/23b05f5fb48215c989e92cc44cf6512512d083132bd3daf689867c8d9d386888/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)