Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storage): use correct host header #5085

Merged
merged 4 commits into from
Sep 18, 2020

Conversation

coryan
Copy link
Member

@coryan coryan commented Sep 18, 2020

Some of our requests were using the wrong Host: header, luckily the
service is forgiving, and the testbench too.

Part of the work for #5072


This change is Reviewable

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 18, 2020
@coryan coryan changed the title fix(storage) use correct host header fix(storage): use correct host header Sep 18, 2020
@coryan coryan force-pushed the fix-storage-use-correct-host-header branch from 119ab28 to c5ce7b9 Compare September 18, 2020 18:23
@codecov
Copy link

codecov bot commented Sep 18, 2020

Codecov Report

Merging #5085 into master will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5085      +/-   ##
==========================================
- Coverage   95.82%   95.82%   -0.01%     
==========================================
  Files         985      986       +1     
  Lines       90210    90236      +26     
==========================================
+ Hits        86445    86469      +24     
- Misses       3765     3767       +2     
Impacted Files Coverage Δ
.../cloud/pubsub/internal/subscription_batch_source.h 100.00% <ø> (ø)
...loud/pubsub/internal/subscription_message_source.h 100.00% <ø> (ø)
google/cloud/pubsub/publisher_options.h 100.00% <ø> (ø)
google/cloud/pubsub/topic_admin_client.h 100.00% <ø> (ø)
google/cloud/storage/internal/curl_client.h 100.00% <ø> (ø)
google/cloud/storage/internal/curl_client.cc 97.28% <100.00%> (+0.01%) ⬆️
google/cloud/storage/internal/curl_wrappers.cc 94.33% <100.00%> (+2.67%) ⬆️
...oogle/cloud/storage/internal/curl_wrappers_test.cc 100.00% <100.00%> (ø)
...bigtable/examples/bigtable_hello_instance_admin.cc 82.02% <0.00%> (-2.25%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 941f562...eae935f. Read the comment docs.

Some of our requests were using the wrong `Host:` header, luckily the
service is forgiving, and the testbench too.
@coryan coryan force-pushed the fix-storage-use-correct-host-header branch from 99d0e71 to 5cad324 Compare September 18, 2020 21:14
@coryan coryan marked this pull request as ready for review September 18, 2020 21:34
@coryan coryan requested a review from a team as a code owner September 18, 2020 21:34
google/cloud/storage/internal/curl_wrappers.cc Outdated Show resolved Hide resolved
@coryan coryan merged commit d05c774 into googleapis:master Sep 18, 2020
@coryan coryan deleted the fix-storage-use-correct-host-header branch September 18, 2020 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants