New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(release): change release.sh to use gh
instead of hub
#7071
Conversation
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
Codecov Report
@@ Coverage Diff @@
## main #7071 +/- ##
==========================================
- Coverage 94.48% 94.48% -0.01%
==========================================
Files 1304 1304
Lines 112377 112377
==========================================
- Hits 106175 106174 -1
- Misses 6202 6203 +1
Continue to review full report at Codecov.
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
@@ -1,11 +1,24 @@ | |||
#!/bin/bash | |||
# | |||
# Copyright 2020 Google LLC |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI: I am not sure the line between #!/bin/bash
and the Copyright notice is needed, in fact, we do have many files that do not have it. Your call.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I never noticed that inconsistency before. It looks like we have 80 shell scripts total, 54 use a blank line, 26 do not. Not sure which way we prefer, but I'd be happy to clean it up in a separate PR. I don't have a strong preference which way we go... well, https://google.github.io/styleguide/shellguide.html#file-header implies a blank line may be preferred, so maybe that's a nudge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SGTM, don't forget the .py
files.
Fixes: #6682
This change is