Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(release): change release.sh to use gh instead of hub #7071

Merged
merged 2 commits into from Jul 28, 2021

Conversation

devjgm
Copy link
Contributor

@devjgm devjgm commented Jul 27, 2021

Fixes: #6682


This change is Reviewable

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 27, 2021
@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: e3d5fd7c4e2b3828d3de6a847e80937ce8120692

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@codecov
Copy link

codecov bot commented Jul 27, 2021

Codecov Report

Merging #7071 (003dbd1) into main (52f263d) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #7071      +/-   ##
==========================================
- Coverage   94.48%   94.48%   -0.01%     
==========================================
  Files        1304     1304              
  Lines      112377   112377              
==========================================
- Hits       106175   106174       -1     
- Misses       6202     6203       +1     
Impacted Files Coverage Δ
google/cloud/grpc_error_delegate.cc 95.83% <0.00%> (-4.17%) ⬇️
...le/cloud/internal/default_completion_queue_impl.cc 97.00% <0.00%> (-0.60%) ⬇️
google/cloud/pubsub/samples/samples.cc 91.67% <0.00%> (-0.08%) ⬇️
...cloud/pubsub/internal/subscription_session_test.cc 98.02% <0.00%> (+0.24%) ⬆️
...torage/examples/storage_service_account_samples.cc 97.64% <0.00%> (+1.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52f263d...003dbd1. Read the comment docs.

@devjgm devjgm marked this pull request as ready for review July 27, 2021 22:07
@devjgm devjgm requested a review from a team as a code owner July 27, 2021 22:07
@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: 003dbd1cb589dd88824fb82e53c345babc646668

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@@ -1,11 +1,24 @@
#!/bin/bash
#
# Copyright 2020 Google LLC
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI: I am not sure the line between #!/bin/bash and the Copyright notice is needed, in fact, we do have many files that do not have it. Your call.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I never noticed that inconsistency before. It looks like we have 80 shell scripts total, 54 use a blank line, 26 do not. Not sure which way we prefer, but I'd be happy to clean it up in a separate PR. I don't have a strong preference which way we go... well, https://google.github.io/styleguide/shellguide.html#file-header implies a blank line may be preferred, so maybe that's a nudge.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM, don't forget the .py files.

@devjgm devjgm merged commit 16c2672 into googleapis:main Jul 28, 2021
@devjgm devjgm deleted the release-cleanup branch July 28, 2021 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

release script usage of hub requires oauth token
3 participants