Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(asset): reenable on macOS #9468

Merged
merged 2 commits into from Jul 18, 2022
Merged

Conversation

dbolduc
Copy link
Member

@dbolduc dbolduc commented Jul 13, 2022

Part of #8145

We require protobuf >= 21.1, which handles TRUE and FALSE macros: https://github.com/protocolbuffers/protobuf/blob/7062d0a2d0075d5e7d5c294fd3984df67a976da3/src/google/protobuf/port_def.inc#L861-L864

We leave the bazel windows build disabled. There is a comment in the linked issue about what breaks.


This change is Reviewable

@product-auto-label product-auto-label bot added the api: cloudasset Issues related to the Cloud Asset Inventory API. label Jul 13, 2022
@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: 01938aa09dddd99a609cb1236e6b2e0922768b25

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@codecov
Copy link

codecov bot commented Jul 13, 2022

Codecov Report

Merging #9468 (0280216) into main (76a4024) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #9468      +/-   ##
==========================================
- Coverage   94.63%   94.63%   -0.01%     
==========================================
  Files        1489     1489              
  Lines      137195   137195              
==========================================
- Hits       129838   129835       -3     
- Misses       7357     7360       +3     
Impacted Files Coverage Δ
...ud/spanner/integration_tests/client_stress_test.cc 85.52% <0.00%> (-0.66%) ⬇️
...cloud/pubsub/internal/subscription_session_test.cc 97.82% <0.00%> (-0.17%) ⬇️
google/cloud/pubsub/samples/samples.cc 92.35% <0.00%> (-0.08%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76a4024...0280216. Read the comment docs.

@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: 0280216fb9e6c8c68e40e86d0ab9772f926eb8d9

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@dbolduc dbolduc marked this pull request as ready for review July 18, 2022 18:11
@dbolduc dbolduc requested a review from a team as a code owner July 18, 2022 18:11
@dbolduc dbolduc merged commit c60524a into googleapis:main Jul 18, 2022
@dbolduc dbolduc deleted the reenable-asset-on-macos branch July 18, 2022 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: cloudasset Issues related to the Cloud Asset Inventory API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants