Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(batch): generate library #9474

Merged
merged 4 commits into from Jul 14, 2022
Merged

feat(batch): generate library #9474

merged 4 commits into from Jul 14, 2022

Conversation

coryan
Copy link
Member

@coryan coryan commented Jul 14, 2022 •
edited

Fixes #9184

This change is Reviewable

@product-auto-label product-auto-label bot added the api: batch Issues related to the Batch API. label Jul 14, 2022
@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: 2e17dba6593c1828dcef1ede2f6120d8a7855290

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@codecov
Copy link

codecov bot commented Jul 14, 2022 •
edited

Codecov Report

Merging #9474 (d938db1) into main (2160d58) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #9474   +/-   ##
=======================================
  Coverage   94.63%   94.63%           
=======================================
  Files        1485     1485           
  Lines      136771   136771           
=======================================
+ Hits       129437   129440    +3     
+ Misses       7334     7331    -3
Impacted Files Coverage Δ
...cloud/pubsub/internal/subscription_session_test.cc 97.98% <0.00%> (+0.16%) ⬆️
...le/cloud/internal/default_completion_queue_impl.cc 97.72% <0.00%> (+0.56%) ⬆️
...torage/examples/storage_service_account_samples.cc 97.64% <0.00%> (+0.58%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2160d58...d938db1. Read the comment docs.

@coryan coryan marked this pull request as ready for review July 14, 2022 04:36
@coryan coryan requested a review from a team as a code owner July 14, 2022 04:36
devbww
devbww reviewed Jul 14, 2022
View reviewed changes
CHANGELOG.md Outdated
We are introducing a new client library for [Cloud Run]. While we do not
anticipate any API changes to this library before declaring it GA, we are
releasing it early in case it elicits some feedback that requires changes.
We are introducing new client libraries for [Cloud Run]. While we do not
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"... and [Cloud Batch]." ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: the branding list does not mention Batch / Cloud Batch. So I tend to use whatever the docs say here:
image

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed (using @dbolduc text)

CHANGELOG.md Outdated

[Cloud Bh]: https://github.com/googleapis/google-cloud-cpp/blob/main/google/cloud/batch/README.md
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And then s/Bh/Batch/ ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto

dbolduc
dbolduc approved these changes Jul 14, 2022
View reviewed changes
Copy link
Member

@dbolduc dbolduc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So we are generating libraries for non-GA services now?

CHANGELOG.md Outdated

[Cloud Bh]: https://github.com/googleapis/google-cloud-cpp/blob/main/google/cloud/batch/README.md
[Cloud Run]: https://github.com/googleapis/google-cloud-cpp/blob/main/google/cloud/run/README.md
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would s/ this whole thing with:

We are introducing 2 new client libraries for GCP services. While we do not
anticipate any API changes to these libraries before declaring them GA, we are
releasing them early in case they elicit some feedback that requires changes.

* [Batch](https://github.com/googleapis/google-cloud-cpp/blob/main/google/cloud/batch/README.md)
* [Cloud Run](https://github.com/googleapis/google-cloud-cpp/blob/main/google/cloud/run/README.md)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@coryan coryan enabled auto-merge (squash) July 14, 2022 13:15
@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: d938db15cc1987e342c94c9badba6de74f5e7e0a

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@coryan coryan merged commit 3ff7dad into googleapis:main Jul 14, 2022
@coryan coryan deleted the feat-batch-generate-library branch July 14, 2022 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devbww devbww devbww left review comments

@dbolduc dbolduc dbolduc approved these changes

Assignees
No one assigned
Labels
api: batch Issues related to the Batch API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Generate library for batch.googleapis.com
4 participants
@coryan @google-cloud-cpp-bot @devbww @dbolduc