Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(common): make the RPC log even more readable #9477

Merged
merged 1 commit into from Jul 14, 2022
Merged

feat(common): make the RPC log even more readable #9477

merged 1 commit into from Jul 14, 2022

Conversation

devbww
Copy link
Collaborator

@devbww devbww commented Jul 14, 2022 •
edited by coryan

  • Expand google.protobuf.Any payloads rather than printing their
    serialized content.
  • Print fields in the order defined in source code instead of by
    the field number.

This change is Reviewable

@devbww
feat(common): make the RPC log even more readable
a87efbf 
- Expand google.protobuf.Any payloads rather than printing their
  serialized content.
- Print fields in the order defined in source code instead of by
  the field number.
@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: a87efbfce7515d1c421dd64a1089570c4ee8ee63

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@codecov
Copy link

codecov bot commented Jul 14, 2022 •
edited

Codecov Report

Merging #9477 (a87efbf) into main (a30eb8b) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #9477      +/-   ##
==========================================
- Coverage   94.64%   94.64%   -0.01%     
==========================================
  Files        1485     1485              
  Lines      136851   136853       +2     
==========================================
+ Hits       129523   129524       +1     
- Misses       7328     7329       +1
Impacted Files Coverage Δ
google/cloud/internal/log_wrapper.cc 77.02% <100.00%> (+0.63%) ⬆️
...cloud/pubsub/internal/subscription_session_test.cc 97.98% <0.00%> (-0.51%) ⬇️
google/cloud/pubsub/samples/samples.cc 92.43% <0.00%> (+0.07%) ⬆️
google/cloud/internal/curl_impl.cc 91.87% <0.00%> (+0.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a30eb8b...a87efbf. Read the comment docs.

@devbww devbww marked this pull request as ready for review July 14, 2022 16:27
@devbww devbww requested a review from a team as a code owner July 14, 2022 16:27
@devbww devbww merged commit 9aa3948 into googleapis:main Jul 14, 2022
@devbww devbww deleted the proto-log-expand-any branch July 14, 2022 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coryan coryan coryan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@devbww @google-cloud-cpp-bot @coryan