Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve error messages for access token errors #9485

Merged

Conversation

coryan
Copy link
Member

@coryan coryan commented Jul 15, 2022

When we fail to generate an access token the errors can be very
confusing. See for example this discussion:

https://issues.apache.org/jira/browse/ARROW-17069

This change is an attempt at making these errors less confusing. They
could be made event better if we had a specific webpage describing
client library authentication and troubleshooting, but we do not have
such a page at the moment.


This change is Reviewable

When we fail to generate an access token the errors can be very
confusing.  See for example this discussion:

https://issues.apache.org/jira/browse/ARROW-17069

This change is an attempt at making these errors less confusing. They
could be made event better if we had a specific webpage describing
client library authentication and troubleshooting, but we do not have
such a page at the moment.
@coryan coryan force-pushed the feat-improve-credential-error-messages branch from 62b1fe6 to 5e0e930 Compare July 15, 2022 15:04
@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: 5e0e9301452f43e45e68a6027868eb20a43935a2

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@codecov
Copy link

codecov bot commented Jul 15, 2022

Codecov Report

Merging #9485 (5e0e930) into main (b529b8c) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #9485   +/-   ##
=======================================
  Coverage   94.64%   94.64%           
=======================================
  Files        1485     1486    +1     
  Lines      136977   136982    +5     
=======================================
+ Hits       129637   129651   +14     
+ Misses       7340     7331    -9     
Impacted Files Coverage Δ
google/cloud/internal/auth_header_error.cc 100.00% <100.00%> (ø)
...oud/internal/oauth2_authorized_user_credentials.cc 100.00% <100.00%> (ø)
...loud/internal/oauth2_compute_engine_credentials.cc 99.06% <100.00%> (ø)
...oud/internal/oauth2_service_account_credentials.cc 97.32% <100.00%> (ø)
google/cloud/storage/internal/curl_client.cc 84.40% <100.00%> (ø)
google/cloud/storage/internal/rest_client.cc 98.79% <100.00%> (+0.10%) ⬆️
...loud/storage/oauth2/authorized_user_credentials.cc 100.00% <100.00%> (ø)
...cloud/storage/oauth2/compute_engine_credentials.cc 100.00% <100.00%> (ø)
...loud/storage/oauth2/service_account_credentials.cc 92.25% <100.00%> (ø)
google/cloud/internal/curl_impl.cc 91.64% <0.00%> (-0.23%) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b529b8c...5e0e930. Read the comment docs.

@coryan coryan marked this pull request as ready for review July 15, 2022 17:55
@coryan coryan requested a review from a team as a code owner July 15, 2022 17:55
@coryan
Copy link
Member Author

coryan commented Jul 16, 2022

/gcbrun

@coryan coryan enabled auto-merge (squash) July 16, 2022 14:54
@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: 5e0e9301452f43e45e68a6027868eb20a43935a2

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@coryan coryan merged commit be4fc98 into googleapis:main Jul 16, 2022
@coryan coryan deleted the feat-improve-credential-error-messages branch July 16, 2022 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants