Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rest): cache credentials #9620

Merged
merged 1 commit into from Aug 2, 2022

Conversation

scotthart
Copy link
Member

@scotthart scotthart commented Aug 2, 2022

fixes #9607


This change is Reviewable

@scotthart scotthart requested a review from a team as a code owner August 2, 2022 18:04
@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: 41279e81409840a81884dcc20b9eec0621f92d38

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

Copy link
Member

@coryan coryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to have a test, but LGTM without it.

@codecov
Copy link

codecov bot commented Aug 2, 2022

Codecov Report

Merging #9620 (41279e8) into main (e8cc9a9) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #9620   +/-   ##
=======================================
  Coverage   94.35%   94.35%           
=======================================
  Files        1488     1488           
  Lines      137709   137711    +2     
=======================================
+ Hits       129936   129942    +6     
+ Misses       7773     7769    -4     
Impacted Files Coverage Δ
google/cloud/internal/curl_rest_client.h 100.00% <ø> (ø)
google/cloud/internal/curl_rest_client.cc 96.89% <100.00%> (+0.04%) ⬆️
google/cloud/storage/parallel_upload.cc 98.26% <0.00%> (-0.35%) ⬇️
...cloud/pubsub/internal/subscription_session_test.cc 98.49% <0.00%> (ø)
google/cloud/internal/curl_impl.cc 89.95% <0.00%> (+0.22%) ⬆️
...le/cloud/internal/default_completion_queue_impl.cc 97.15% <0.00%> (+0.56%) ⬆️
...loud/bigtable/internal/connection_refresh_state.cc 98.61% <0.00%> (+2.77%) ⬆️
...e/cloud/pubsublite/internal/alarm_registry_impl.cc 100.00% <0.00%> (+2.94%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8cc9a9...41279e8. Read the comment docs.

@scotthart scotthart merged commit be39fb9 into googleapis:main Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cache credentials instead of creating new ones per RPC
3 participants