Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bigtable): per-operation Options (pt. 2) #9627

Merged
merged 1 commit into from Aug 4, 2022

Conversation

dbolduc
Copy link
Member

@dbolduc dbolduc commented Aug 3, 2022

Fixes #7688

Accept Options in the (Async)ReadModifyWriteRow(..., Args&& rules_and_options) parameter packs. (I dare you to improve on the name: rules_and_options).

We extract the options using GroupOptions(...). And ignore Options when we are adding rules to the request proto.


This change is Reviewable

@product-auto-label product-auto-label bot added the api: bigtable Issues related to the Bigtable API. label Aug 3, 2022
@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: e518a1479c5371d4f5f2ff12589167281b9b023a

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@codecov
Copy link

codecov bot commented Aug 3, 2022

Codecov Report

Merging #9627 (e518a14) into main (fe748ba) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #9627   +/-   ##
=======================================
  Coverage   94.36%   94.37%           
=======================================
  Files        1488     1488           
  Lines      138043   138105   +62     
=======================================
+ Hits       130270   130330   +60     
- Misses       7773     7775    +2     
Impacted Files Coverage Δ
google/cloud/bigtable/legacy_table_test.cc 100.00% <100.00%> (ø)
google/cloud/bigtable/table.cc 99.42% <100.00%> (+<0.01%) ⬆️
google/cloud/bigtable/table.h 98.55% <100.00%> (+0.05%) ⬆️
google/cloud/bigtable/table_test.cc 100.00% <100.00%> (ø)
...e/cloud/pubsublite/internal/alarm_registry_impl.cc 97.05% <0.00%> (-2.95%) ⬇️
...cloud/pubsub/internal/subscription_session_test.cc 98.15% <0.00%> (-0.84%) ⬇️
google/cloud/pubsub/samples/samples.cc 90.70% <0.00%> (-0.08%) ⬇️
google/cloud/storage/parallel_upload.cc 98.61% <0.00%> (+0.34%) ⬆️
google/cloud/bigtable/read_modify_write_rule.h 90.47% <0.00%> (+0.47%) ⬆️
...e/cloud/spanner/testing/cleanup_stale_instances.cc 72.22% <0.00%> (+11.11%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@dbolduc dbolduc marked this pull request as ready for review August 4, 2022 02:55
@dbolduc dbolduc requested a review from a team as a code owner August 4, 2022 02:55
@dbolduc dbolduc merged commit ab81c8c into googleapis:main Aug 4, 2022
@dbolduc dbolduc deleted the bigtable-operation-options-pr-4 branch August 4, 2022 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigtable Issues related to the Bigtable API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add bigtable support for per-operation options
3 participants