Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(storage): equality for Native IAM types #9649

Merged

Conversation

dbolduc
Copy link
Member

@dbolduc dbolduc commented Aug 8, 2022

Part of the work for #2310

The types are:

  • storage::NativeExpression
  • storage::NativeIamBinding
  • storage::NativeIamPolicy

And I was too lazy to do this internal type in a separate PR:

  • storage::internal::PatchBuilder

This change is Reviewable

@product-auto-label product-auto-label bot added the api: storage Issues related to the Cloud Storage API. label Aug 8, 2022
@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: 65f47239128e2a7e06cab02880e2b741ef5b604e

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@codecov
Copy link

codecov bot commented Aug 8, 2022

Codecov Report

Merging #9649 (0af2b5e) into main (a508bb6) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #9649   +/-   ##
=======================================
  Coverage   94.35%   94.36%           
=======================================
  Files        1493     1493           
  Lines      138786   138839   +53     
=======================================
+ Hits       130956   131012   +56     
+ Misses       7830     7827    -3     
Impacted Files Coverage Δ
google/cloud/storage/iam_policy.cc 98.92% <100.00%> (+1.19%) ⬆️
google/cloud/storage/internal/patch_builder.cc 83.60% <100.00%> (+3.09%) ⬆️
...oogle/cloud/storage/internal/patch_builder_test.cc 92.24% <100.00%> (+0.44%) ⬆️
google/cloud/storage/storage_iam_policy_test.cc 100.00% <100.00%> (ø)
...bigtable/examples/bigtable_hello_instance_admin.cc 81.00% <0.00%> (-2.00%) ⬇️
...ud/spanner/integration_tests/client_stress_test.cc 84.21% <0.00%> (-0.66%) ⬇️
google/cloud/pubsub/subscriber_connection_test.cc 97.75% <0.00%> (-0.57%) ⬇️
...e/cloud/pubsublite/internal/alarm_registry_impl.cc 100.00% <0.00%> (+2.94%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: 0af2b5e6cd39017e05de5501505a1a68c07eff1d

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@dbolduc dbolduc marked this pull request as ready for review August 8, 2022 03:49
@dbolduc dbolduc requested a review from a team as a code owner August 8, 2022 03:49
@dbolduc dbolduc merged commit 7cd4c4c into googleapis:main Aug 8, 2022
@dbolduc dbolduc deleted the storage-equality-for-copyable-classes branch August 8, 2022 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the Cloud Storage API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants