Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bigtable): support GOOGLE_CLOUD_ENABLE_DIRECT_PATH #9978

Merged
merged 1 commit into from Oct 5, 2022

Conversation

dbolduc
Copy link
Member

@dbolduc dbolduc commented Oct 4, 2022

Fixes #4382 and basically undoes #6175

I set up a VM with the magic subnet. If I set the endpoint as such and make some request, I see that my gRPC peer is 2001:4860:8040:...etc.....

Note that google-c2p:///bigtable.googleapis.com requires the project to be allow-listed.


This change is Reviewable

@product-auto-label product-auto-label bot added the api: bigtable Issues related to the Bigtable API. label Oct 4, 2022
@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: 723f3e3ec088ab135b4a4a16c8d01e199ff4490a

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@codecov
Copy link

codecov bot commented Oct 4, 2022

Codecov Report

Base: 94.21% // Head: 94.21% // No change to project coverage 👍

Coverage data is based on head (883e249) compared to base (883e249).
Patch has no changes to coverable lines.

❗ Current head 883e249 differs from pull request most recent head 723f3e3. Consider uploading reports for the commit 723f3e3 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9978   +/-   ##
=======================================
  Coverage   94.21%   94.21%           
=======================================
  Files        1500     1500           
  Lines      140570   140570           
=======================================
  Hits       132434   132434           
  Misses       8136     8136           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dbolduc dbolduc marked this pull request as ready for review October 4, 2022 21:09
@dbolduc dbolduc requested a review from a team as a code owner October 4, 2022 21:09
@dbolduc dbolduc merged commit 1edffee into googleapis:main Oct 5, 2022
@dbolduc dbolduc deleted the cbt-c2p branch October 5, 2022 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigtable Issues related to the Bigtable API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support DirectPath for Cloud Bigtable
3 participants