Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pubsub): faster shutdowns for Publisher #9991

Merged

Conversation

coryan
Copy link
Member

@coryan coryan commented Oct 6, 2022

Cancel the timer (if any) before shutting down. This can be a problem for applications that have very long batches (say multiple seconds or minutes).


This change is Reviewable

Cancel the timer (if any) before shutting down.  This can be a problem
for applications that have very long batches (say multiple seconds or
minutes).
@product-auto-label product-auto-label bot added the api: pubsub Issues related to the Pub/Sub API. label Oct 6, 2022
@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: de1664f9ab00770f5e9437c1d79738e236e6e8ac

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@codecov
Copy link

codecov bot commented Oct 6, 2022

Codecov Report

Base: 94.21% // Head: 94.22% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (de1664f) compared to base (fb40389).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9991   +/-   ##
=======================================
  Coverage   94.21%   94.22%           
=======================================
  Files        1501     1501           
  Lines      140650   140674   +24     
=======================================
+ Hits       132520   132545   +25     
+ Misses       8130     8129    -1     
Impacted Files Coverage Δ
...ud/pubsub/internal/batching_publisher_connection.h 100.00% <ø> (ø)
...d/pubsub/internal/batching_publisher_connection.cc 100.00% <100.00%> (ø)
...sub/internal/batching_publisher_connection_test.cc 99.44% <100.00%> (-0.18%) ⬇️
...e/cloud/spanner/testing/cleanup_stale_instances.cc 75.40% <0.00%> (-3.28%) ⬇️
...cloud/pubsub/internal/subscription_session_test.cc 98.49% <0.00%> (+0.50%) ⬆️
...integration_tests/schema_admin_integration_test.cc 100.00% <0.00%> (+1.11%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@coryan coryan marked this pull request as ready for review October 6, 2022 22:51
@coryan coryan requested a review from a team as a code owner October 6, 2022 22:51
Copy link
Member

@scotthart scotthart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @coryan)

@coryan coryan merged commit 5792587 into googleapis:main Oct 7, 2022
@coryan coryan deleted the fix-pubsub-speedup-publisher-shutdown branch October 7, 2022 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the Pub/Sub API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants