Pubsub: Fully enable ordering-keys (#3921)

googleapis · Dec 18, 2019 · d859592 · d859592
1 parent bb028ac
commit d859592
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 4 deletions.
diff --git a/apis/Google.Cloud.PubSub.V1/Google.Cloud.PubSub.V1/AssemblyInfo.cs b/apis/Google.Cloud.PubSub.V1/Google.Cloud.PubSub.V1/AssemblyInfo.cs
@@ -15,4 +15,3 @@
 using System.Runtime.CompilerServices;
 
 [assembly: InternalsVisibleTo("Google.Cloud.PubSub.V1.Tests, PublicKey=0024000004800000940000000602000000240000525341310004000001000100afab79952ee22215f12b4e09337e65509c943fbc22d7006bc371d581d0f0ebf0da5d8039aab2607fb68a138a5d80a71bc02b7ebf586dbe1f2493c0ab20423ababfd15ce74d2264a6b37745f3658f016abaad662182aaef634a60f1346fcc45343acab5b6781535a3134818e13fac895a6c106c0480e34bbb06cb123e5583d8d2")]
-[assembly: InternalsVisibleTo("Google.Cloud.PubSub.V1.OrderingKeyTester, PublicKey=0024000004800000940000000602000000240000525341310004000001000100afab79952ee22215f12b4e09337e65509c943fbc22d7006bc371d581d0f0ebf0da5d8039aab2607fb68a138a5d80a71bc02b7ebf586dbe1f2493c0ab20423ababfd15ce74d2264a6b37745f3658f016abaad662182aaef634a60f1346fcc45343acab5b6781535a3134818e13fac895a6c106c0480e34bbb06cb123e5583d8d2")]
diff --git a/apis/Google.Cloud.PubSub.V1/Google.Cloud.PubSub.V1/PublisherClient.cs b/apis/Google.Cloud.PubSub.V1/Google.Cloud.PubSub.V1/PublisherClient.cs
@@ -69,13 +69,11 @@ internal Settings(Settings other)
             /// </summary>
             public IScheduler Scheduler { get; set; }
 
-            // TODO: Make this property public when the ordering-keys feature is available in the service.
-            //       And remove the InternalsVisibleTo for the OrderingKeyTester
             /// <summary>
             /// Enable message ordering. It is invalid to set <see cref="PubsubMessage.OrderingKey"/> in a message
             /// if this has not been set to <c>true</c>.
             /// </summary>
-            internal bool EnableMessageOrdering { get; set; }
+            public bool EnableMessageOrdering { get; set; }
 
             internal void Validate()
             {