NLog GoogleStackdriverTarget improve handling of dangerous object pro…

…perties that throws exceptions during Json.Net serialization. (#3668)
googleapis · Oct 28, 2019 · e708f35 · e708f35
1 parent 3f9b1d0
commit e708f35
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/apis/Google.Cloud.Logging.NLog/Google.Cloud.Logging.NLog/GoogleStackdriverTarget.cs b/apis/Google.Cloud.Logging.NLog/Google.Cloud.Logging.NLog/GoogleStackdriverTarget.cs
@@ -135,6 +135,12 @@ protected override void InitializeTarget()
                 ReferenceLoopHandling = Newtonsoft.Json.ReferenceLoopHandling.Ignore
             };
             jsonSettings.Converters.Add(new Newtonsoft.Json.Converters.StringEnumConverter());
+            jsonSettings.Error = (sender, args) =>
+            {
+                // Serialization of properties that throws exceptions should not break everything
+                InternalLogger.Warn(args.ErrorContext.Error, "GoogleStackdriver(Name={0}): Error serializing exception property: {1}", Name, args.ErrorContext.Member);
+                args.ErrorContext.Handled = true;
+            };
             var jsonSerializer = Newtonsoft.Json.JsonSerializer.CreateDefault(jsonSettings);
             return o => {
                 try