Skip to content

Commit

Permalink
feat: Tune Secret Manager auto retry parameters
Browse files Browse the repository at this point in the history
UNKNOWN removed from retryable errors per AIP-194. Added RESOURCE_EXHAUSTED with adjusted parameters for better performance with spikes of AccessSecretVersion requests at or near quota limits.

PiperOrigin-RevId: 383886699

Source-Author: Google APIs <noreply@google.com>
Source-Date: Fri Jul 9 11:25:36 2021 -0700
Source-Repo: googleapis/googleapis
Source-Sha: 1eade8161f2ef102282869bc3eb18841807b2b46
Source-Link: googleapis/googleapis@1eade81
  • Loading branch information
yoshi-automation authored and jskeet committed Jul 10, 2021
1 parent c13f1e3 commit edf114d
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -173,14 +173,14 @@ private SecretManagerServiceSettings(SecretManagerServiceSettings existing) : ba
/// </summary>
/// <remarks>
/// <list type="bullet">
/// <item><description>Initial retry delay: 1000 milliseconds.</description></item>
/// <item><description>Retry delay multiplier: 1.3</description></item>
/// <item><description>Initial retry delay: 2000 milliseconds.</description></item>
/// <item><description>Retry delay multiplier: 2</description></item>
/// <item><description>Retry maximum delay: 60000 milliseconds.</description></item>
/// <item><description>Maximum attempts: Unlimited</description></item>
/// <item><description>Maximum attempts: 5</description></item>
/// <item><description>Timeout: 60 seconds.</description></item>
/// </list>
/// </remarks>
public gaxgrpc::CallSettings AccessSecretVersionSettings { get; set; } = gaxgrpc::CallSettingsExtensions.WithRetry(gaxgrpc::CallSettings.FromExpiration(gax::Expiration.FromTimeout(sys::TimeSpan.FromMilliseconds(60000))), gaxgrpc::RetrySettings.FromExponentialBackoff(maxAttempts: 2147483647, initialBackoff: sys::TimeSpan.FromMilliseconds(1000), maxBackoff: sys::TimeSpan.FromMilliseconds(60000), backoffMultiplier: 1.3, retryFilter: gaxgrpc::RetrySettings.FilterForStatusCodes(grpccore::StatusCode.Unavailable, grpccore::StatusCode.Unknown)));
public gaxgrpc::CallSettings AccessSecretVersionSettings { get; set; } = gaxgrpc::CallSettingsExtensions.WithRetry(gaxgrpc::CallSettings.FromExpiration(gax::Expiration.FromTimeout(sys::TimeSpan.FromMilliseconds(60000))), gaxgrpc::RetrySettings.FromExponentialBackoff(maxAttempts: 5, initialBackoff: sys::TimeSpan.FromMilliseconds(2000), maxBackoff: sys::TimeSpan.FromMilliseconds(60000), backoffMultiplier: 2, retryFilter: gaxgrpc::RetrySettings.FilterForStatusCodes(grpccore::StatusCode.Unavailable, grpccore::StatusCode.ResourceExhausted)));

/// <summary>
/// <see cref="gaxgrpc::CallSettings"/> for synchronous and asynchronous calls to
Expand Down
2 changes: 1 addition & 1 deletion apis/Google.Cloud.SecretManager.V1/synth.metadata
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"git": {
"name": "googleapis",
"remote": "https://github.com/googleapis/googleapis.git",
"sha": "bff807490f09712527b1af607160a4f7ae48702e"
"sha": "1eade8161f2ef102282869bc3eb18841807b2b46"
}
}
]
Expand Down

0 comments on commit edf114d

Please sign in to comment.