Implement StartOffset and EndOffset in ListObjectsOptions

Fixes #4993.
googleapis · May 28, 2020 · fbcca00 · fbcca00
1 parent db4f9a9
commit fbcca00
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 1 deletion.
diff --git a/apis/Google.Cloud.Storage.V1/Google.Cloud.Storage.V1.Tests/ListObjectsOptionsTest.cs b/apis/Google.Cloud.Storage.V1/Google.Cloud.Storage.V1.Tests/ListObjectsOptionsTest.cs
@@ -33,6 +33,8 @@ public void ModifyRequest_DefaultOptions()
             Assert.Null(request.Versions);
             Assert.Null(request.UserProject);
             Assert.Null(request.PageToken);
+            Assert.Null(request.StartOffset);
+            Assert.Null(request.EndOffset);
         }
 
         [Fact]
@@ -48,7 +50,9 @@ public void ModifyRequest_AllOptions()
                 Versions = true,
                 UserProject = "proj",
                 PageToken = "nextpage",
-                Fields = "items(name),nextPageToken"
+                Fields = "items(name),nextPageToken",
+                StartOffset = "start",
+                EndOffset = "end"
             };
             options.ModifyRequest(request);
             Assert.Equal(10, request.MaxResults);
@@ -59,6 +63,8 @@ public void ModifyRequest_AllOptions()
             Assert.Equal("proj", request.UserProject);
             Assert.Equal("nextpage", request.PageToken);
             Assert.Equal("items(name),nextPageToken", request.Fields);
+            Assert.Equal("start", request.StartOffset);
+            Assert.Equal("end", request.EndOffset);
         }
     }
 }
diff --git a/apis/Google.Cloud.Storage.V1/Google.Cloud.Storage.V1/ListObjectsOptions.cs b/apis/Google.Cloud.Storage.V1/Google.Cloud.Storage.V1/ListObjectsOptions.cs
@@ -80,6 +80,18 @@ public sealed class ListObjectsOptions
         /// </summary>
         public string Fields { get; set; }
 
+        /// <summary>
+        /// If set, filters results to objects whose names are lexicographically equal to or after
+        /// this value. (Objects whose names are exactly the start offset are included.)
+        /// </summary>
+        public string StartOffset { get; set; }
+
+        /// <summary>
+        /// If set, filters results to objects whose names are lexicographically before
+        /// this value. (Objects whose names are exactly the end offset are excluded.)
+        /// </summary>
+        public string EndOffset { get; set; }
+
         /// <summary>
         /// Modifies the specified request for all non-null properties of this options object.
         /// </summary>
@@ -118,6 +130,14 @@ internal void ModifyRequest(ListRequest request)
             {
                 request.Fields = Fields;
             }
+            if (StartOffset != null)
+            {
+                request.StartOffset = StartOffset;
+            }
+            if (EndOffset != null)
+            {
+                request.EndOffset = EndOffset;
+            }
         }
     }
 }