[apis/Google.Cloud.PubSub.V1] feat: Add support for server-side streaming pull flow control #5119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
|
Chris, do you have the bandwidth to review this? |
|
What's the user-visible change here? It looks like it's not a public API surface change. It looks like it's just sending more information to the server, which I guess leads to increased efficiency? |
|
Correct, this is not user-visible. It just propagates settings that were already used in the client to the server since the StreamingPullRequest now has theses fields and can use them. For now, this is mostly about correctness for ordered delivery via ordering keys. |
|
@kamalaboulhosn Thanks. Will work out something to put in the next release notes :) What's the sense of urgency in terms of including this in a release? |
jskeet
added a commit
to jskeet/google-cloud-dotnet
that referenced
this pull request
Aug 3, 2020
Changes in this release: - [Commit 330b04e](googleapis@330b04e): Fix: PubSub methods will now be retried appropriately. Fixes [issue 5225](googleapis#5225) - [Commit 0cd128c](googleapis@0cd128c): docs: Remove experimental warning for ordering keys properties. ([issue 5219](googleapis#5219)) - [Commit 6bde7a3](googleapis@6bde7a3): docs: Regenerate all APIs with service comments in client documentation - [Commit 6165e07](googleapis@6165e07): feat: Add support for server-side streaming pull flow control ([issue 5119](googleapis#5119)) - [Commit 2c5f3c1](googleapis@2c5f3c1): feat: Add flow control settings for StreamingPullRequest to pubsub.proto - [Commit b5500f5](googleapis@b5500f5): docs: Add a link to Pub/Sub filtering language public documentation to pubsub.proto - [Commit ac924f2](googleapis@ac924f2): feat: Add "detached" bool to Subscription - [Commit f3eeca0](googleapis@f3eeca0): docs: Add comment for MessageStoragePolicy message - [Commit 1dae64f](googleapis@1dae64f): fix: Use correct resource type for DetachSubscriptionRequest - [Commit 5f5b8aa](googleapis@5f5b8aa): feat: DetachSubscription RPC - [Commit 947a573](googleapis@947a573): docs: Regenerate all clients with more explicit documentation - [Commit 777b926](googleapis@777b926): docs: Removing the experimental tag from dead letter policy related fields. - [Commit 8cd3929](googleapis@8cd3929): docs: Removing experimental tag from DeadLetterPolicy for Cloud Pub/Sub.
jskeet
added a commit
that referenced
this pull request
Aug 3, 2020
Changes in this release: - [Commit 330b04e](330b04e): Fix: PubSub methods will now be retried appropriately. Fixes [issue 5225](#5225) - [Commit 0cd128c](0cd128c): docs: Remove experimental warning for ordering keys properties. ([issue 5219](#5219)) - [Commit 6bde7a3](6bde7a3): docs: Regenerate all APIs with service comments in client documentation - [Commit 6165e07](6165e07): feat: Add support for server-side streaming pull flow control ([issue 5119](#5119)) - [Commit 2c5f3c1](2c5f3c1): feat: Add flow control settings for StreamingPullRequest to pubsub.proto - [Commit b5500f5](b5500f5): docs: Add a link to Pub/Sub filtering language public documentation to pubsub.proto - [Commit ac924f2](ac924f2): feat: Add "detached" bool to Subscription - [Commit f3eeca0](f3eeca0): docs: Add comment for MessageStoragePolicy message - [Commit 1dae64f](1dae64f): fix: Use correct resource type for DetachSubscriptionRequest - [Commit 5f5b8aa](5f5b8aa): feat: DetachSubscription RPC - [Commit 947a573](947a573): docs: Regenerate all clients with more explicit documentation - [Commit 777b926](777b926): docs: Removing the experimental tag from dead letter policy related fields. - [Commit 8cd3929](8cd3929): docs: Removing experimental tag from DeadLetterPolicy for Cloud Pub/Sub.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.