fix: allow setting parameter size to the same as the current value #7401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some frameworks (NHibernate) will automatically set the parameter size to either the default value (zero) or to a value that is copied from another parameter. This fails for parameters that are not of type String or Bytes for Spanner, although there is no reason to fail in that case, as the actual state of the parameter does not change to an invalid state. This change makes setting the size of a parameter to the same value as the current value a no-op.
google-cla
bot
added
the
cla: yes
jskeet
approved these changes
Oct 27, 2021
jskeet
added a commit
to jskeet/google-cloud-dotnet
that referenced
this pull request
Dec 1, 2021
Changes in Google.Cloud.Spanner.Data version 3.13.0: - [Commit 02b16d7](googleapis@02b16d7): fix: clone each SpannerParameter when cloning a parameter collection - [Commit c653720](googleapis@c653720): feat: add support for DataReader.GetBytes ([issue 7395](googleapis#7395)) - [Commit 9bc116d](googleapis@9bc116d): fix: allow setting parameter size to the same as the current value ([issue 7401](googleapis#7401)) - [Commit 0666123](googleapis@0666123): feat: Spanner Read API Packages in this release: - Release Google.Cloud.Spanner.Admin.Database.V1 version 3.13.0 - Release Google.Cloud.Spanner.Admin.Instance.V1 version 3.13.0 - Release Google.Cloud.Spanner.Common.V1 version 3.13.0 - Release Google.Cloud.Spanner.Data version 3.13.0 - Release Google.Cloud.Spanner.V1 version 3.13.0
jskeet
added a commit
that referenced
this pull request
Dec 1, 2021
Changes in Google.Cloud.Spanner.Data version 3.13.0: - [Commit 02b16d7](02b16d7): fix: clone each SpannerParameter when cloning a parameter collection - [Commit c653720](c653720): feat: add support for DataReader.GetBytes ([issue 7395](#7395)) - [Commit 9bc116d](9bc116d): fix: allow setting parameter size to the same as the current value ([issue 7401](#7401)) - [Commit 0666123](0666123): feat: Spanner Read API Packages in this release: - Release Google.Cloud.Spanner.Admin.Database.V1 version 3.13.0 - Release Google.Cloud.Spanner.Admin.Instance.V1 version 3.13.0 - Release Google.Cloud.Spanner.Common.V1 version 3.13.0 - Release Google.Cloud.Spanner.Data version 3.13.0 - Release Google.Cloud.Spanner.V1 version 3.13.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some frameworks (NHibernate) will automatically set the parameter size to either the default
value (zero) or to a value that is copied from another parameter. This fails for parameters
that are not of type String or Bytes for Spanner, although there is no reason to fail in that
case, as the actual state of the parameter does not change to an invalid state. This change
makes setting the size of a parameter to the same value as the current value a no-op.