Add simpler support for GqlQueryParameters #899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that this only populated a GqlQueryParameter with a Value, never a Cursor. While we could add overloads for cursors, the parameter type would be ByteString... which can also be converted to Value. So I'm basically betting that when you've got a ByteString, you're more likely to want to use it as a Value parameter than as a Cursor parameter. Fixes googleapis#887
gcf-owl-bot bot
added a commit
that referenced
this pull request
Apr 30, 2024
Source-Link: googleapis/googleapis@55499b5 Source-Link: googleapis/googleapis-gen@cf5049b Copy-Tag: eyJwIjoiYXBpcy9Hb29nbGUuQ2xvdWQuQ29tcHV0ZS5WMS8uT3dsQm90LnlhbWwiLCJoIjoiY2Y1MDQ5YjcwNzkyODIwMDY1ZGIzOGU3MTI3ZjMyZWFiNzcwNTk0NCJ9
gcf-owl-bot bot
added a commit
that referenced
this pull request
Apr 30, 2024
Source-Link: googleapis/googleapis@55499b5 Source-Link: googleapis/googleapis-gen@cf5049b Copy-Tag: eyJwIjoiYXBpcy9Hb29nbGUuQ2xvdWQuQ29tcHV0ZS5WMS8uT3dsQm90LnlhbWwiLCJoIjoiY2Y1MDQ5YjcwNzkyODIwMDY1ZGIzOGU3MTI3ZjMyZWFiNzcwNTk0NCJ9
gcf-owl-bot bot
added a commit
that referenced
this pull request
Apr 30, 2024
Source-Link: googleapis/googleapis@55499b5 Source-Link: googleapis/googleapis-gen@cf5049b Copy-Tag: eyJwIjoiYXBpcy9Hb29nbGUuQ2xvdWQuQ29tcHV0ZS5WMS8uT3dsQm90LnlhbWwiLCJoIjoiY2Y1MDQ5YjcwNzkyODIwMDY1ZGIzOGU3MTI3ZjMyZWFiNzcwNTk0NCJ9
jskeet
pushed a commit
that referenced
this pull request
Apr 30, 2024
Source-Link: googleapis/googleapis@55499b5 Source-Link: googleapis/googleapis-gen@cf5049b Copy-Tag: eyJwIjoiYXBpcy9Hb29nbGUuQ2xvdWQuQ29tcHV0ZS5WMS8uT3dsQm90LnlhbWwiLCJoIjoiY2Y1MDQ5YjcwNzkyODIwMDY1ZGIzOGU3MTI3ZjMyZWFiNzcwNTk0NCJ9
jskeet
added a commit
that referenced
this pull request
May 8, 2024
Changes in this release: ### New features - Update Compute Engine API to revision 20240430 ([issue 900](#900)) ([commit 95da052](95da052)) - Update Compute Engine API to revision 20240421 ([issue 899](#899)) ([commit cc0431c](cc0431c)) - Update Compute Engine API to revision 20240407 ([issue 890](#890)) ([commit ee6c6f0](ee6c6f0)) - Add IServiceCollection extension methods for client registration where an IServiceProvider is required. ([commit 022fab2](022fab2))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that this only populated a GqlQueryParameter with a Value, never a Cursor.
While we could add overloads for cursors, the parameter type would be ByteString...
which can also be converted to Value. So I'm basically betting that when you've got a
ByteString, you're more likely to want to use it as a Value parameter than as a Cursor
parameter.
Fixes #887