feat: Exposed RpcException property to SpannerException #9527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anuragsrivstv
added
do not merge
jskeet
reviewed
Jan 10, 2023
| @@ -93,6 +93,11 @@ public bool IsRetryable | |||
| /// </summary> | |||
| public TimeSpan? RecommendedRetryDelay { get; } | |||
|
|
|||
| /// <summary> | |||
| /// Gets the underlying <see cref="Grpc.Core.RpcException"/>. | |||
There was a problem hiding this comment.
I would reword "Gets" to "Returns", but more importantly point out that this may be null, if the SpannerException was not caused by an RpcException.
jskeet
reviewed
Jan 10, 2023
| namespace Google.Cloud.Spanner.Data.Tests; | ||
| public class SpannerExceptionTests | ||
| { | ||
| private static readonly Status s_status = new Status(StatusCode.InvalidArgument, "Bad request"); |
There was a problem hiding this comment.
Just move into the single test that uses it, as a local variable?
| public void SpannerExceptionContainsRpcExceptionAsInnerException() | ||
| { | ||
| var rpcExceptionMessage = "Test RpcException Message"; | ||
| var rpcexception = new RpcException(s_status, rpcExceptionMessage); |
There was a problem hiding this comment.
Nit: rename to rpcException.
|
|
||
| var spannerExceptionWithoutInnerExcpetion = new SpannerException(ErrorCode.InvalidArgument, "Invalid Argument Message"); | ||
|
|
||
| Assert.NotNull(spannerExceptionWithInnerExcpetion_1.RpcException); |
There was a problem hiding this comment.
I think these can just be Assert.Same(rpcException, spannerExceptionWithInnerExcpetion_1.RpcException);
| var rpcExceptionMessage = "Test RpcException Message"; | ||
| var rpcexception = new RpcException(s_status, rpcExceptionMessage); | ||
|
|
||
| var spannerExceptionWithInnerExcpetion_1 = new SpannerException(rpcexception); |
There was a problem hiding this comment.
Nit: Excpetion => Exception, and I'd lose the underscores.
anuragsrivstv
removed
the
do not merge
jskeet
approved these changes
Jan 10, 2023
jskeet
added a commit
that referenced
this pull request
Feb 8, 2023
Changes in Google.Cloud.Spanner.Data version 4.3.0: - Enable REST transport in C# ([commit f6a1c3e](f6a1c3e)) - Exposed RpcException property to SpannerException ([issue 9527](#9527)) ([commit 4c96a04](4c96a04)) Packages in this release: - Release Google.Cloud.Spanner.Admin.Database.V1 version 4.3.0 - Release Google.Cloud.Spanner.Admin.Instance.V1 version 4.3.0 - Release Google.Cloud.Spanner.Common.V1 version 4.3.0 - Release Google.Cloud.Spanner.Data version 4.3.0 - Release Google.Cloud.Spanner.V1 version 4.3.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we have exposed InnerException of SpannerException via RpcException property.