fix(spanner): handle nil error when cleaning up long running session (#…

…9052)
googleapis · Nov 29, 2023 · a93bc26 · a93bc26
1 parent a1aecb0
commit a93bc26
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/spanner/session.go b/spanner/session.go
@@ -724,6 +724,12 @@ func (p *sessionPool) getLongRunningSessionsLocked() []*sessionHandle {
 		for element != nil {
 			sh := element.Value.(*sessionHandle)
 			sh.mu.Lock()
+			if sh.session == nil {
+				// sessionHandle has already been recycled/destroyed.
+				sh.mu.Unlock()
+				element = element.Next()
+				continue
+			}
 			diff := time.Now().Sub(sh.lastUseTime)
 			if !sh.eligibleForLongRunning && diff.Seconds() >= p.idleTimeThreshold.Seconds() {
 				if (p.ActionOnInactiveTransaction == Warn || p.ActionOnInactiveTransaction == WarnAndClose) && !sh.isSessionLeakLogged {