-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
spanner: TestIntegration_BatchQuery failed #1922
Comments
Looks like this issue is flaky. 😟 I'm going to leave this open and stop commenting. A human should fix and close this. commit: 891bf76 |
@skuruppu These flaky failures are caused by |
@olavloite, oh I see. Does that mean we could do a similar thing to what you proposed for Java where we add a retry loop for non-idempotent RPCs? |
@olavloite if you can implement the same fix for Go as you did for Java, I think that would help. |
@skuruppu Yes, I'll have a look. |
Background info: |
Oops! Looks like this issue is still flaky. It failed again. 😬 I reopened the issue, but a human will need to close it again. commit: 3bcbd5d |
Oops! Looks like this issue is still flaky. It failed again. 😬 I reopened the issue, but a human will need to close it again. commit: 3bcbd5d |
Oops! Looks like this issue is still flaky. It failed again. 😬 I reopened the issue, but a human will need to close it again. commit: 3bcbd5d |
This is related to googleapis/go-genproto#366, which has been fixed. |
Oops! Looks like this issue is still flaky. It failed again. 😬 I reopened the issue, but a human will need to close it again. commit: abe7c9a |
1 similar comment
Oops! Looks like this issue is still flaky. It failed again. 😬 I reopened the issue, but a human will need to close it again. commit: abe7c9a |
@olavloite This is caused by a nil pointer reference in a different test: |
Yes, while fixing a flaky test case in https://code-review.googlesource.com/c/gocloud/+/56990 I forgot to commit one of the files. Kokoro gave the green light, even though the build panicked with the same error as here, so it was merged in. It was fixed shortly after in https://code-review.googlesource.com/c/gocloud/+/56991. |
Thanks. I will close this then. |
This test failed!
To configure my behavior, see the Build Cop Bot documentation.
If I'm commenting on this issue too often, add the
buildcop: quiet
label andI will stop commenting.
commit: 891bf76
buildURL: Build Status, Sponge
status: failed
The text was updated successfully, but these errors were encountered: