Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pubsublite/internal/wire: TestSubscribeStreamSpuriousSeekResponse failed #3329

Closed
flaky-bot bot opened this issue Dec 2, 2020 · 1 comment · Fixed by #3388
Closed

pubsublite/internal/wire: TestSubscribeStreamSpuriousSeekResponse failed #3329

flaky-bot bot opened this issue Dec 2, 2020 · 1 comment · Fixed by #3388
Assignees
@tmdiep
Labels
api: pubsublite Issues related to the Pub/Sub Lite API. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@flaky-bot
Copy link

flaky-bot bot commented Dec 2, 2020

This test failed!

To configure my behavior, see the Build Cop Bot documentation.

If I'm commenting on this issue too often, add the buildcop: quiet label and
I will stop commenting.

commit: fe64496
buildURL: Build Status, Sponge
status: failed

Test output
subscriber_test.go:363: Start() got err: (pubsublite: received seek response for no in-flight seek)
@flaky-bot flaky-bot bot added buildcop: issue priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Dec 2, 2020
@product-auto-label product-auto-label bot added the api: pubsublite Issues related to the Pub/Sub Lite API. label Dec 2, 2020
@flaky-bot
Copy link
Author

flaky-bot bot commented Dec 2, 2020

Looks like this issue is flaky. 😟

I'm going to leave this open and stop commenting.

A human should fix and close this.

When run at the same commit (fe64496), this test passed in one build (Build Status, Sponge) and failed in another build (Build Status, Sponge).

@codyoss codyoss mentioned this issue Dec 3, 2020
Merged
codyoss added a commit that referenced this issue Dec 3, 2020
@codyoss
test(pubsublite): skip TestSubscribeStreamSpuriousSeekResponse (#3350)
cd753df 
Will be fixed with #3329.
@tmdiep tmdiep mentioned this issue Dec 4, 2020
Merged
tmdiep added a commit that referenced this issue Dec 7, 2020
@tmdiep
test(pubsublite): fix flaky subscriber stream tests (#3388)
b28e0b8 
Fixes #3329 and other similar instances.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tmdiep tmdiep

Labels
api: pubsublite Issues related to the Pub/Sub Lite API. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test(pubsublite): fix flaky subscriber stream tests tmdiep/google-cloud-go
1 participant
@tmdiep