Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

logging: default bundler limits doesn't match official API #3823

Closed
loburm opened this issue Mar 16, 2021 · 1 comment · Fixed by #4247
Closed

logging: default bundler limits doesn't match official API #3823

loburm opened this issue Mar 16, 2021 · 1 comment · Fixed by #4247
Assignees
@0xSage
Labels
api: logging Issues related to the Cloud Logging API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@loburm
Copy link
Contributor

loburm commented Mar 16, 2021

Client

Logging

Code

That's a limit that we see inside of package:

	// DefaultEntryCountThreshold is the default value for the EntryCountThreshold LoggerOption.
	DefaultEntryCountThreshold = 1000

	// DefaultEntryByteThreshold is the default value for the EntryByteThreshold LoggerOption.
	DefaultEntryByteThreshold = 1 << 20 // 1MiB

	// DefaultBufferedByteLimit is the default value for the BufferedByteLimit LoggerOption.
	DefaultBufferedByteLimit = 1 << 30 // 1GiB

I'm not 100% sure what is the difference between DefaultEntryByteThreshold and DefaultBufferedByteLimit, but official API has a different limits:

Size of a log entry 256 KB
Size of an entries.write request 10 MB
@loburm loburm added the triage me I really want to be triaged. label Mar 16, 2021
@product-auto-label product-auto-label bot added the api: logging Issues related to the Cloud Logging API. label Mar 16, 2021
@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label Mar 21, 2021
@0xSage 0xSage added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. and removed 🚨 This issue needs some love. triage me I really want to be triaged. labels Mar 22, 2021
@0xSage
Copy link
Contributor

0xSage commented Jun 11, 2021

good pt, i think we are just using bundler defaults see here

ill get in a pr to raise these defaults to something that makes more sense given actual api limits

@0xSage 0xSage mentioned this issue Jun 11, 2021
Merged
gcf-merge-on-green bot pushed a commit that referenced this issue Jun 29, 2021
@0xSage
feat(logging)!: increase DefaultEntryByteThreshold to 8Mb (#4247)
f32dd72 
Fixes: #3823 

DefaultEntryByteThreshold = `1 << 20 // 1MiB` ===> `1 << 23 // 8MiB` since size of an entries.write request	can be up to 10 MB. 

`DefaultBufferedByteLimit` is unchanged as that's more a cap on memory utilization.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@0xSage 0xSage

Labels
api: logging Issues related to the Cloud Logging API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(logging)!: increase DefaultEntryByteThreshold to 8Mb googleapis/google-cloud-go
3 participants
@loburm @yoshi-automation @0xSage