Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spanner: Batch read transactions miss support for RPC Priority and Tagging #3904

Closed
olavloite opened this issue Apr 8, 2021 · 0 comments · Fixed by #3905
Closed

spanner: Batch read transactions miss support for RPC Priority and Tagging #3904

olavloite opened this issue Apr 8, 2021 · 0 comments · Fixed by #3905
Assignees
@olavloite
Labels
api: spanner Issues related to the Spanner API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@olavloite
Copy link
Contributor

Batch read transactions miss WithOptions methods that allow an application to pass in an RpcPriority and/or tags for the requests.

First reported in #3896
@olavloite olavloite added the type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. label Apr 8, 2021
@olavloite olavloite self-assigned this Apr 8, 2021
@product-auto-label product-auto-label bot added the api: spanner Issues related to the Spanner API. label Apr 8, 2021
olavloite added a commit that referenced this issue Apr 8, 2021
@olavloite
feat(spanner): enable request options for batch read
aafb687 
Enables RequestOptions (priority and tagging) for batch read transactions.
This problem was first reported in #3896.

Fixes #3904
@olavloite olavloite mentioned this issue Apr 8, 2021
Merged
@zoercai zoercai added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Apr 13, 2021
@hengfengli hengfengli removed their assignment Apr 13, 2021
skuruppu pushed a commit that referenced this issue Apr 21, 2021
@olavloite
feat(spanner): enable request options for batch read (#3905)
0c73db2 
Enables RequestOptions (priority and tagging) for batch read transactions.
This problem was first reported in #3896.

Fixes #3904
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@olavloite olavloite

Labels
api: spanner Issues related to the Spanner API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(spanner): enable request options for batch read googleapis/google-cloud-go
3 participants
@hengfengli @olavloite @zoercai