Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compute/metadata): return an error when all retries have failed #5063

Merged
merged 3 commits into from
Nov 3, 2021

Conversation

Deiz
Copy link
Contributor

@Deiz Deiz commented Nov 2, 2021

Minor change to ensure an error is returned to the caller when all retries have failed.

Fixes #5062

@Deiz Deiz requested a review from a team as a code owner November 2, 2021 15:07
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 2, 2021
@product-auto-label product-auto-label bot added the api: compute Issues related to the Compute Engine API. label Nov 2, 2021
@codyoss codyoss added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 2, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 2, 2021
codyoss
codyoss previously approved these changes Nov 2, 2021
Copy link
Member

@codyoss codyoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for the error report and contribution!

@codyoss codyoss added the automerge: exact Summon MOG for automerging, but approvals need to be against the latest commit label Nov 2, 2021
@codyoss
Copy link
Member

codyoss commented Nov 2, 2021

@Deiz Would you mind updating the PR. This repo is decently high traffic and can be hard to land things in sometimes. If you tick the box allow edits from maintains I can help update and get this is. Thanks!

@Deiz
Copy link
Contributor Author

Deiz commented Nov 2, 2021

Have at it 🙂

@gcf-merge-on-green gcf-merge-on-green bot dismissed codyoss’s stale review November 2, 2021 23:52

This review does not reference the most recent commit, and you are using the secure version of merge-on-green. Please re-review the most recent commit.

@gcf-merge-on-green
Copy link
Contributor

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge: exact Summon MOG for automerging, but approvals need to be against the latest commit label Nov 3, 2021
@codyoss codyoss added kokoro:force-run Add this label to force Kokoro to re-run the tests. automerge: exact Summon MOG for automerging, but approvals need to be against the latest commit labels Nov 3, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 3, 2021
@gcf-merge-on-green
Copy link
Contributor

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge: exact Summon MOG for automerging, but approvals need to be against the latest commit label Nov 3, 2021
@codyoss codyoss added kokoro:force-run Add this label to force Kokoro to re-run the tests. automerge: exact Summon MOG for automerging, but approvals need to be against the latest commit labels Nov 3, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 3, 2021
@codyoss codyoss merged commit c792a0d into googleapis:master Nov 3, 2021
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge: exact Summon MOG for automerging, but approvals need to be against the latest commit label Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: compute Issues related to the Compute Engine API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

compute/metadata: short description of bug
3 participants