fix(bigquery/storage/managedwriter): correct enum processing in NormalizeDescriptor #5811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Report from googleapis#5794 demonstrates backend rejection when you have an external enum that's re-used across multiple nested messages. Unclear if this should be resolved in the backend or if we should detect re-use and/or build a dependency cache for this kind of thing.
shollyman
added
the
do not merge
product-auto-label
bot
added
size: l
|
shollyman
removed
the
do not merge
shollyman
changed the title
steffnay
approved these changes
Mar 30, 2022
shollyman
added a commit
to shollyman/google-cloud-go
that referenced
this pull request
Mar 30, 2022
Make the enum append more consistent, missed during the initial fix in googleapis#5811
shollyman
added a commit
that referenced
this pull request
Mar 30, 2022
Make the enum append more consistent, missed during the initial fix in #5811
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Report from #5794 demonstrates backend rejection when you have
an external enum that's re-used across multiple nested messages.
Fix is straightforward. Enum processing was incorrectly adding the enum message in the current child, rather than within the root descriptor. This PR addresses that, and augments testing.
Fixes: #5794