Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(bigquery/storage/managedwriter): correct enum processing in NormalizeDescriptor #5811

Merged
merged 3 commits into from
Mar 30, 2022
Merged

fix(bigquery/storage/managedwriter): correct enum processing in NormalizeDescriptor #5811

merged 3 commits into from
Mar 30, 2022

Commits on Mar 29, 2022

  1. test(bigquery/storage/managedwriter): test embedded enums 

    Report from googleapis#5794 demonstrates backend rejection when you have
an external enum that's re-used across multiple nested messages.

Unclear if this should be resolved in the backend or if we should
detect re-use and/or build a dependency cache for this kind of thing.
    @shollyman
    shollyman committed Mar 29, 2022
    Configuration menu
    Copy the full SHA
    90c9bb6 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into fr-nested-enum

    @shollyman
    shollyman committed Mar 29, 2022
    Configuration menu
    Copy the full SHA
    1b28590 View commit details
    Browse the repository at this point in the history

  3. apply fix to enum processor, update tests

    @shollyman
    shollyman committed Mar 29, 2022
    Configuration menu
    Copy the full SHA
    edda74f View commit details
    Browse the repository at this point in the history