Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

datastore: uncomment !=, in, and not-in test cases in integration_test #6184

Closed
telpirion opened this issue Jun 15, 2022 · 2 comments · Fixed by #6728
Closed

datastore: uncomment !=, in, and not-in test cases in integration_test #6184

telpirion opened this issue Jun 15, 2022 · 2 comments · Fixed by #6728
Assignees
@telpirion
Labels
api: datastore Issues related to the Datastore API. type: cleanup An internal cleanup or hygiene concern.

Comments

@telpirion
Copy link
Contributor

The test GCP project for this repro needs updating to allow usage of the !=, in, and not-in operators. Once this update has occurred, we need to uncomment the integration tests for these operations.
@telpirion telpirion added the triage me I really want to be triaged. label Jun 15, 2022
@product-auto-label product-auto-label bot added the api: datastore Issues related to the Datastore API. label Jun 15, 2022
@telpirion telpirion added type: cleanup An internal cleanup or hygiene concern. and removed triage me I really want to be triaged. labels Jun 15, 2022
@telpirion telpirion mentioned this issue Jun 15, 2022
Merged
@tekkamanendless
Copy link

Are you referring to the Datastore emulator? As of July 2 (the last time that I checked), the emulator does not support the new operators, but the production Datastore does.

@telpirion
Copy link
Contributor Author

That's good to know that you're seeing these features in prod! Thank you @tekkamanendless .

@telpirion telpirion mentioned this issue Sep 23, 2022
Merged
gcf-merge-on-green bot pushed a commit that referenced this issue Sep 23, 2022
test(datastore): uncomments in, not-in, and != tests (#6728)
0ffce1d 
Fixes #6184
telpirion pushed a commit that referenced this issue Sep 27, 2022
test(datastore): uncomments in, not-in, and != tests (#6728)
b6a0d31 
Fixes #6184
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@telpirion telpirion

Labels
api: datastore Issues related to the Datastore API. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test(datastore): uncomments in, not-in, and != tests googleapis/google-cloud-go
2 participants
@tekkamanendless @telpirion