feat(storage): export ShouldRetry #6370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Export the default func to determine whether an error is retryable. This makes it easier for users to use the WithErrorFunc option without copying a lot of code. Fixes googleapis#6362
product-auto-label
bot
added
size: m
tritone
commented
Jul 19, 2022
| @@ -1229,7 +1229,7 @@ func (r *gRPCReader) Close() error { | |||
| // an attempt to reopen the stream. | |||
| func (r *gRPCReader) recv() (*storagepb.ReadObjectResponse, error) { | |||
| msg, err := r.stream.Recv() | |||
| if err != nil && shouldRetry(err) { | |||
| if err != nil && ShouldRetry(err) { | |||
There was a problem hiding this comment.
Note: ShouldRetry should not be referenced directly here; instead we should be using the configured value from the retry configuration passed through the interface. Will file a separate bug to fix this up. FYI @noahdietz
noahdietz
approved these changes
Aug 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Export the default func to determine whether an error is retryable.
This makes it easier for users to use the WithErrorFunc option
without copying a lot of code.
Fixes #6362