Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage: TestIntegration_ACL failed #6579

Closed
flaky-bot bot opened this issue Aug 28, 2022 · 5 comments · Fixed by #6585, #6618 or #6645
Closed

storage: TestIntegration_ACL failed #6579

flaky-bot bot opened this issue Aug 28, 2022 · 5 comments · Fixed by #6585, #6618 or #6645
Assignees
Labels
api: storage Issues related to the Cloud Storage API. flakybot: flaky Tells the Flaky Bot not to close or comment on this issue. flakybot: issue An issue filed by the Flaky Bot. Should not be added manually. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@flaky-bot
Copy link

flaky-bot bot commented Aug 28, 2022

Note: #6379 was also for this test, but it was closed more than 10 days ago. So, I didn't mark it flaky.


commit: c220ca2
buildURL: Build Status, Sponge
status: failed

Test output
    integration_test.go:2373: hasRule: object ACL missing {Entity:domain-google.com EntityID: Role:READER Domain:google.com Email: ProjectTeam:}
    integration_test.go:2377: object ACL: could not delete entity domain-google.com
@flaky-bot flaky-bot bot added flakybot: issue An issue filed by the Flaky Bot. Should not be added manually. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Aug 28, 2022
@product-auto-label product-auto-label bot added the api: storage Issues related to the Cloud Storage API. label Aug 28, 2022
@flaky-bot flaky-bot bot added the flakybot: flaky Tells the Flaky Bot not to close or comment on this issue. label Aug 28, 2022
@flaky-bot
Copy link
Author

flaky-bot bot commented Aug 28, 2022

Looks like this issue is flaky. 😟

I'm going to leave this open and stop commenting.

A human should fix and close this.


When run at the same commit (c220ca2), this test passed in one build (Build Status, Sponge) and failed in another build (Build Status, Sponge).

@flaky-bot
Copy link
Author

flaky-bot bot commented Sep 2, 2022

Oops! Looks like this issue is still flaky. It failed again. 😬

I reopened the issue, but a human will need to close it again.


commit: 9f3c334
buildURL: Build Status, Sponge
status: failed

Test output
    integration_test.go:2377: hasRule: object ACL missing {Entity:domain-google.com EntityID: Role:READER Domain:google.com Email: ProjectTeam:}
    integration_test.go:2381: object ACL: could not delete entity domain-google.com

@BenWhitehead BenWhitehead added priority: p2 Moderately-important priority. Fix may not be included in next release. and removed priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. labels Sep 6, 2022
tritone added a commit to tritone/google-cloud-go that referenced this issue Sep 6, 2022
Previously the docs said that these operations would take effect
within 10s, but I noticed that at some point this was loosened
up to "at least 30s" and "about a minute" depending on the
location. I think these tests will still usually run in a similar
amount of time, but hopefully extending this timeout will avoid
some flakes.

https://cloud.google.com/storage/docs/consistency#eventually_consistent_operations
https://cloud.google.com/storage/docs/access-control/lists#modification-rules
 (see note above)

Fixes googleapis#6579
tritone added a commit that referenced this issue Sep 7, 2022
Previously the docs said that these operations would take effect
within 10s, but I noticed that at some point this was loosened
up to "at least 30s" and "about a minute" depending on the
location. I think these tests will still usually run in a similar
amount of time, but hopefully extending this timeout will avoid
some flakes.

https://cloud.google.com/storage/docs/consistency#eventually_consistent_operations
https://cloud.google.com/storage/docs/access-control/lists#modification-rules
 (see note above)

Fixes #6579
@flaky-bot flaky-bot bot reopened this Sep 7, 2022
@flaky-bot
Copy link
Author

flaky-bot bot commented Sep 7, 2022

Oops! Looks like this issue is still flaky. It failed again. 😬

I reopened the issue, but a human will need to close it again.


commit: 5733a42
buildURL: Build Status, Sponge
status: failed

Test output
    integration_test.go:2377: hasRule: object ACL missing {Entity:domain-google.com EntityID: Role:READER Domain:google.com Email: ProjectTeam:}
    integration_test.go:2381: object ACL: could not delete entity domain-google.com

@tritone
Copy link
Contributor

tritone commented Sep 8, 2022

Latest failure was from a commit before my fix was merged. Therefore I'm going to close this again.

@tritone tritone closed this as completed Sep 8, 2022
@flaky-bot
Copy link
Author

flaky-bot bot commented Sep 8, 2022

Oops! Looks like this issue is still flaky. It failed again. 😬

I reopened the issue, but a human will need to close it again.


commit: 1ad1aba
buildURL: Build Status, Sponge
status: failed

Test output
    integration_test.go:2377: hasRule: object ACL missing {Entity:domain-google.com EntityID: Role:READER Domain:google.com Email: ProjectTeam:}
    integration_test.go:2381: object ACL: could not delete entity domain-google.com

@flaky-bot flaky-bot bot reopened this Sep 8, 2022
tritone added a commit to tritone/google-cloud-go that referenced this issue Sep 9, 2022
I realized that this section had been slightly messed up in
the integration test refactor for retries; we need the object
creation to be retried as well if the check fails.

Also removed superfluous unused object name.

Fixes googleapis#6579
tritone added a commit that referenced this issue Sep 9, 2022
I realized that this section had been slightly messed up in
the integration test refactor for retries; we need the object
creation to be retried as well if the check fails.

Also removed superfluous unused object name.

Fixes #6579
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the Cloud Storage API. flakybot: flaky Tells the Flaky Bot not to close or comment on this issue. flakybot: issue An issue filed by the Flaky Bot. Should not be added manually. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
2 participants