feat(internal/postprocessor): make OwlBot postprocessor #7202

adrianajg · 2023-01-03T21:50:29Z

OwlBot will be configured to copy generated files directly into their corresponding client directories. When triggered by the OwlBot automation robot, the postprocessor performs the following tasks:

run $ go mod tidy in all repo directories
run $ gofmt -s -d -w -l . in all repo directories
regenerate snippets for all clients
write manifest file with info about all gapic configurations
update pull request title and description, amending commit titles to match Conventional Commit format
- The amended PR title and description are written to a file in a well-known-location, which OwlBot uses to amend the open PR
- The .github.OwlBot.yaml file must include an api-name field with the value REPLACEME in order to label all commit messages with the placeholder scope '[REPLACEME]'.

feat(postprocessor): integrate OwlBot locally and add basic post-processor to copy generated code into libraries

…utput directory for snippets to go into local repo internal/generated/snippets

…ient and lints that same client, skips all others

refactor(internal): Move gensnippets files to internal

…ig.go. Move cloning of google-cloud-go to main()

…of '/repo'

…tprocessor

…into OwlBot3

feat(postprocessor): rewrite OwlBot PR title and body commits to include scope

…tprocessor

snippet-bot · 2023-01-03T23:04:02Z

Here is the summary of possible violations 😱

There is a possible violation for not having product prefix.

internal/gensnippets/gensnippets.go:393, tag %v

There is a format violation for a region tag.

internal/gensnippets/gensnippets.go:393, tag %v

The end of the violation section. All the stuff below is FYI purposes only.

Here is the summary of changes.

You are about to add 1 region tag.

internal/gensnippets/gensnippets.go:393, tag %v

You are about to delete 1 region tag.

internal/gapicgen/gensnippets/gensnippets.go:382, tag %v

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

Refresh this comment

codyoss

Two small nits and the PR needs to be updated and resolve a merge conflict.

internal/postprocessor/main.go

internal/postprocessor/main_test.go

…tprocessor

noahdietz

Cool stuff @adrianajg ! If any of my comments refer to code that was strictly moved directories, feel free to ignore them. They are all style nits anyways :)

internal/gensnippets/gensnippets.go

internal/postprocessor/README.md

internal/postprocessor/execv/command.go

internal/postprocessor/execv/gocmd/gocmd.go

adrianajg

Thanks for the review! I addressed your comments, sometimes with additional tweaks. I also updated the README.md as I noticed there was some outdated info there. Let me know if you see anything else.

internal/gensnippets/gensnippets.go

internal/postprocessor/README.md

internal/postprocessor/execv/command.go

internal/postprocessor/execv/gocmd/gocmd.go

codyoss

LGTM, thanks

quartzmo · 2023-01-09T23:20:27Z

🎉

adrianajg and others added 30 commits October 20, 2022 10:10

deleted all changes other than postprocessor take 2

222759e

refactor

5a7c3f5

address issues in code review

1211045

refactor code

ca74a92

Run ModTidyAll from postprocessor after copying files

7ef9aa2

Implement execv Vet command

979fc14

Make edits according to code review

4a4eef1

removing .OwlBot files from GitHub

20f57d2

re-added .OwlBot files locally

c6ae219

Merge pull request #1 from adrianajg/OwlBot

f9762d0

feat(postprocessor): integrate OwlBot locally and add basic post-processor to copy generated code into libraries

move gensnippets to internal

4ec20e4

fix build errors

913adbb

resetting changes to fix build issues

4b350ee

Generate snippets from postprocessor

bee6ebe

gensnippet.Generate function being called when running postprocessor

6f4e8e1

Fix flags for local testing without Docker build. Fix regenSnippets o…

9e863db

…utput directory for snippets to go into local repo internal/generated/snippets

Testing only copies accessapproval library from owl-bot-staging to cl…

6528c51

…ient and lints that same client, skips all others

Using local test flag generates gensnippets for accessapproval library

09edb81

Call to built postprocessor container generates snippets for all modules

db7fbbf

Refactor code

852bf44

Merge pull request #3 from adrianajg/OwlBot3

f785afe

refactor(internal): Move gensnippets files to internal

Remove bigquery/reservation entry in internal/gapicgen/generator/conf…

85a0e8d

…ig.go. Move cloning of google-cloud-go to main()

reverted gensnippets.Generate function to set rootDir to '.' instead …

9dd2fb1

…of '/repo'

Change dstPrefix flag default value to '/repo'

8595a7c

Do not clone if testing flag set to True

809f730

Remove unecessary if testing in run()

4ec16c2

refactoring in progress

c5e9543

Merge branch 'main' of github.com:googleapis/google-cloud-go into Pos…

cbd760f

…tprocessor

Merge branch 'Postprocessor' of github.com:adrianajg/google-cloud-go …

eebcfa0

…into OwlBot3

merged

0515e02

adrianajg and others added 8 commits December 7, 2022 16:02

clean up

cb2af9a

Test run on accessapproval with full postprocessor script worked

7cdc324

reset branchPrefix flag to default of 'owl-bot-copy-'

ee53795

restructure and resolve review issues

37caa90

Resolve changes 2

c713d11

addressing further requested changes

059d10b

trying to pass vet check

f85d4fd

Merge pull request #6 from adrianajg/CommitMessages

986587e

feat(postprocessor): rewrite OwlBot PR title and body commits to include scope

product-auto-label bot added the size: xl Pull request size is extra large. label Jan 3, 2023

adrianajg added 2 commits January 3, 2023 16:57

Merge branch 'main' of github.com:googleapis/google-cloud-go into Pos…

4bce4d5

…tprocessor

format

4d69e8e

adrianajg marked this pull request as ready for review January 3, 2023 23:03

adrianajg requested a review from a team as a code owner January 3, 2023 23:03

codyoss requested changes Jan 6, 2023

View reviewed changes

internal/postprocessor/main.go Outdated Show resolved Hide resolved

internal/postprocessor/main_test.go Outdated Show resolved Hide resolved

adrianajg added 3 commits January 6, 2023 11:49

Address requested changes

e7d42bd

Merge branch 'main' of github.com:googleapis/google-cloud-go into Pos…

4dbe3d0

…tprocessor

removed unecessary import

4e9426e

noahdietz reviewed Jan 6, 2023

View reviewed changes

adrianajg commented Jan 6, 2023

View reviewed changes

Further requested changes

e8a0fc2

codyoss approved these changes Jan 6, 2023

View reviewed changes

adrianajg and others added 2 commits January 6, 2023 17:36

formatting

3b545c0

Merge branch 'main' into Postprocessor

0db44cf

noahdietz approved these changes Jan 6, 2023

View reviewed changes

Merge branch 'main' into Postprocessor

662577d

codyoss merged commit 7a1022e into googleapis:main Jan 9, 2023

codyoss deleted the Postprocessor branch January 9, 2023 21:46

release-please bot mentioned this pull request Jan 9, 2023

chore(main): release 0.109.0 #7226

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(internal/postprocessor): make OwlBot postprocessor #7202

feat(internal/postprocessor): make OwlBot postprocessor #7202

adrianajg commented Jan 3, 2023 •

edited

snippet-bot bot commented Jan 3, 2023 •

edited

codyoss left a comment

noahdietz left a comment

adrianajg left a comment

codyoss left a comment

quartzmo commented Jan 9, 2023

feat(internal/postprocessor): make OwlBot postprocessor #7202

feat(internal/postprocessor): make OwlBot postprocessor #7202

Conversation

adrianajg commented Jan 3, 2023 • edited

snippet-bot bot commented Jan 3, 2023 • edited

codyoss left a comment

Choose a reason for hiding this comment

noahdietz left a comment

Choose a reason for hiding this comment

adrianajg left a comment

Choose a reason for hiding this comment

codyoss left a comment

Choose a reason for hiding this comment

quartzmo commented Jan 9, 2023

adrianajg commented Jan 3, 2023 •

edited

snippet-bot bot commented Jan 3, 2023 •

edited