Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(storage): add ComponentCount as part of ObjectAttrs #7230

Merged
merged 9 commits into from
Jan 11, 2023
Merged

feat(storage): add ComponentCount as part of ObjectAttrs #7230

merged 9 commits into from
Jan 11, 2023

Conversation

Tulsishah
Copy link
Contributor

No description provided.

@Tulsishah Tulsishah requested review from a team as code owners January 10, 2023 11:06
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Jan 10, 2023
@Tulsishah Tulsishah changed the title Adding Component Count as a part of ObjectAttrs type in storage library Adding ComponentCount Attribute as a part of ObjectAttrs type in storage library Jan 10, 2023
@codyoss codyoss changed the title Adding ComponentCount Attribute as a part of ObjectAttrs type in storage library feat(storage): Adding ComponentCount Attribute as a part of ObjectAttrs type in storage library Jan 10, 2023
tritone
tritone reviewed Jan 10, 2023
View reviewed changes
Copy link
Contributor

@tritone tritone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor comments, otherwise looks good.

storage/storage.go Outdated Show resolved Hide resolved
storage/integration_test.go Outdated Show resolved Hide resolved
@tritone tritone added the kokoro:run Add this label to force Kokoro to re-run the tests. label Jan 10, 2023
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Jan 10, 2023
tritone
tritone approved these changes Jan 10, 2023
View reviewed changes
Copy link
Contributor

@tritone tritone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending presubmit run

@tritone tritone changed the title feat(storage): Adding ComponentCount Attribute as a part of ObjectAttrs type in storage library feat(storage): add ComponentCount as part of ObjectAttrs Jan 10, 2023
tritone
tritone reviewed Jan 11, 2023
View reviewed changes
Copy link
Contributor

@tritone tritone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after fixing attrToProto method

storage/storage.go Outdated Show resolved Hide resolved
@Tulsishah Tulsishah requested review from tritone and removed request for tritone January 11, 2023 15:20
@tritone tritone added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 11, 2023
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 11, 2023
@tritone tritone added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 11, 2023
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 11, 2023
@tritone tritone merged commit a19bca6 into googleapis:main Jan 11, 2023
@release-please release-please bot mentioned this pull request Jan 11, 2023
Merged
@tritone tritone mentioned this pull request Jan 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tritone tritone tritone approved these changes

Assignees
No one assigned
Labels
size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Tulsishah @tritone @kokoro-team