Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

storage: TestIntegration_PredefinedACLs failed #7653

Closed
flaky-bot bot opened this issue Mar 30, 2023 · 4 comments · Fixed by #8313
Closed

storage: TestIntegration_PredefinedACLs failed #7653

flaky-bot bot opened this issue Mar 30, 2023 · 4 comments · Fixed by #8313
Assignees
@tritone
Labels
api: storage Issues related to the Cloud Storage API. flakybot: flaky Tells the Flaky Bot not to close or comment on this issue. flakybot: issue An issue filed by the Flaky Bot. Should not be added manually. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@flaky-bot
Copy link

flaky-bot bot commented Mar 30, 2023

Note: #7472 was also for this test, but it was closed more than 10 days ago. So, I didn't mark it flaky.

commit: 760329e
buildURL: Build Status, Sponge
status: failed

Test output
    integration_test.go:3895: Object.ACL: expected acl to contain: {entity:allAuthenticatedUsers role:READER}, got acl: [{Entity:allUsers EntityID: Role:READER Domain: Email: ProjectTeam:} {Entity:user-kokoro@dulcet-port-762.iam.gserviceaccount.com EntityID: Role:OWNER Domain: Email:kokoro@dulcet-port-762.iam.gserviceaccount.com ProjectTeam:}]
@flaky-bot flaky-bot bot added flakybot: issue An issue filed by the Flaky Bot. Should not be added manually. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Mar 30, 2023
@product-auto-label product-auto-label bot added the api: storage Issues related to the Cloud Storage API. label Mar 30, 2023
@flaky-bot
Copy link
Author

flaky-bot bot commented Mar 30, 2023

Test passed for commit 3f1ed9c (Build Status, Sponge)! Closing this issue.

@flaky-bot flaky-bot bot closed this as completed Mar 30, 2023
@flaky-bot flaky-bot bot reopened this Apr 4, 2023
@flaky-bot
Copy link
Author

flaky-bot bot commented Apr 4, 2023

Looks like this issue is flaky. 😟

I'm going to leave this open and stop commenting.

A human should fix and close this.

commit: 40ea7a4
buildURL: Build Status, Sponge
status: failed

Test output
    integration_test.go:3895: Object.ACL: expected acl to contain: {entity:allAuthenticatedUsers role:READER}, got acl: [{Entity:allUsers EntityID: Role:READER Domain: Email: ProjectTeam:} {Entity:user-kokoro@dulcet-port-762.iam.gserviceaccount.com EntityID: Role:OWNER Domain: Email:kokoro@dulcet-port-762.iam.gserviceaccount.com ProjectTeam:}]

@flaky-bot flaky-bot bot added the flakybot: flaky Tells the Flaky Bot not to close or comment on this issue. label Apr 4, 2023
@tritone tritone added priority: p2 Moderately-important priority. Fix may not be included in next release. and removed priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. labels Apr 17, 2023
This was referenced Jun 15, 2023
Closed
Closed
Closed
Closed
Closed
@cojenco
Copy link
Contributor

cojenco commented Jul 21, 2023 •
edited

PredefinedACLs test failed in June for another reason (new formatting projects/_/buckets/<bucketID> enforced ) and was fixed via #8159

This failed test last occurred in April; Potentially closing if we can verify if (a) this was an one-off incident in April and is no longer causing issues or (b) addressed by recent test fixes #8165

@cojenco
Copy link
Contributor

cojenco commented Jul 21, 2023

Update - the PredefinedACLs test relies on eventual consistency; applying a retry or wait around it should unflake the test

@cojenco cojenco mentioned this issue Jul 21, 2023
Merged
gcf-merge-on-green bot pushed a commit that referenced this issue Jul 26, 2023
@cojenco
test(storage): add retry to ACL tests that rely on eventual consisten…
954fb0b 
…cy (#8313)

This adds retry in the PredefinedACLs integration test that relies on eventual consistency

Fixes #7653
@flaky-bot flaky-bot bot mentioned this issue Aug 30, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tritone tritone

Labels
api: storage Issues related to the Cloud Storage API. flakybot: flaky Tells the Flaky Bot not to close or comment on this issue. flakybot: issue An issue filed by the Flaky Bot. Should not be added manually. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test(storage): add retry to ACL tests that rely on eventual consistency cojenco/google-cloud-go
2 participants
@tritone @cojenco