Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

storage: round up Chunksize value to nearest multiple of 256kib [GRPC] #7754

Closed
BrennaEpp opened this issue Apr 13, 2023 · 0 comments · Fixed by #7799
Closed

storage: round up Chunksize value to nearest multiple of 256kib [GRPC] #7754

BrennaEpp opened this issue Apr 13, 2023 · 0 comments · Fixed by #7799
Assignees
@tritone
Labels
api: storage Issues related to the Cloud Storage API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@BrennaEpp
Copy link
Contributor

In HTTP we round the value for Writer.Chunksize up to the nearest multiple on 256kib.

We should do the same for GRPC, so that setting the Chunksize to a value such as 96 does not return an error, as is the case for HTTP.
@BrennaEpp BrennaEpp added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Apr 13, 2023
@product-auto-label product-auto-label bot added the api: storage Issues related to the Cloud Storage API. label Apr 13, 2023
BrennaEpp added a commit to BrennaEpp/google-cloud-go that referenced this issue Apr 20, 2023
@BrennaEpp
chore(storage): round up Chunksize to nearest multiple of 256kib [GRPC]
b68e03c 
Fixes googleapis#7754
@BrennaEpp BrennaEpp mentioned this issue Apr 20, 2023
Merged
BrennaEpp added a commit that referenced this issue May 1, 2023
@BrennaEpp
chore(storage): round up Chunksize to nearest multiple of 256kib [GRP…
ca738ab 
…C] (#7799)

Fixes #7754

GRPC skipped due to #7798 affecting the last test chunksize 0 uploads everything

Also cleans up a typo in ProgressFunc docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tritone tritone

Labels
api: storage Issues related to the Cloud Storage API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(storage): round up Chunksize to nearest multiple of 256kib [GRPC] BrennaEpp/google-cloud-go
2 participants
@tritone @BrennaEpp