Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apidiff: matrix caps out at 256 items #7939

Closed
noahdietz opened this issue May 15, 2023 · 1 comment · Fixed by #7991
Closed

apidiff: matrix caps out at 256 items #7939

noahdietz opened this issue May 15, 2023 · 1 comment · Fixed by #7991
Assignees
@noahdietz
Labels
type: process A process-related concern. May include testing, release, or the like.

Comments

@noahdietz
Copy link
Contributor

The strategy.matrix used in the apidiff.yml workflow caps out at 256 jobs. Anything over that limit is silently ignored. This is a problem because there could be breaking changes in those packages that are ignored.

As such, it would be better if we could diff modules rather than packages. Unfortunately, apidiff doesn't support comparing modules. From the README:

The current version of apidiff compares only packages, not modules.
@noahdietz noahdietz added the type: process A process-related concern. May include testing, release, or the like. label May 15, 2023
@noahdietz noahdietz self-assigned this May 15, 2023
@noahdietz noahdietz mentioned this issue May 16, 2023
Closed
@noahdietz
Copy link
Contributor Author

Since golang/go#60213 was fixed, we can now move to a module-based diff to save on workflow jobs spawned.

@noahdietz noahdietz mentioned this issue May 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@noahdietz noahdietz

Labels
type: process A process-related concern. May include testing, release, or the like.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(ci): apidiff module mode with changefinder noahdietz/google-cloud-go
1 participant
@noahdietz