fix(firestore): Cleanup integration test resources #8057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: s
enocom
approved these changes
Jun 7, 2023
firestore/integration_test.go
Outdated
| } | ||
| } | ||
| } | ||
|
|
||
| func cleanupIntegrationTest() { | ||
| if iClient != nil { | ||
| // TODO(jba): delete everything in integrationColl. |
There was a problem hiding this comment.
Does this TODO have any significance? If not, I'd suggest deleting it since jba no longer works on this project.
There was a problem hiding this comment.
Removed todo. Added cleanup of collection
enocom
approved these changes
Jun 7, 2023
enocom
approved these changes
Jun 7, 2023
product-auto-label
bot
added
size: m
bhshkh
changed the title
product-auto-label
bot
added
api: firestore
noahdietz
added
the
automerge
|
This is good to go in my view. |
enocom
approved these changes
Jun 12, 2023
noahdietz
approved these changes
Jun 12, 2023
gcf-merge-on-green
bot
removed
the
automerge
xwkuang5
pushed a commit
to xwkuang5/google-cloud-go
that referenced
this pull request
Jun 13, 2023
…nto agg-add-trace * 'agg-add-trace' of github.com:xwkuang5/google-cloud-go: Fix formating. chore(firestore): Add bloom filter related comments (googleapis#8079) fix(firestore): Cleanup integration test resources (googleapis#8057) fix(datastore): Handling nil slices in save and query (googleapis#8043)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing #7998
Builds are failing with below error because composite indexes weren't getting cleared:
"You have reached the maximum number of indexes per database. Please delete an unused index and try again."