feat(spanner): add databoost property for batch transactions #8152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gauravpurohit06
approved these changes
Jun 20, 2023
gauravpurohit06
suggested changes
Jun 20, 2023
harshachinta
requested review from
gauravpurohit06 and
olavloite
and removed request for
gauravpurohit06
gauravpurohit06
approved these changes
Jun 20, 2023
olavloite
approved these changes
Jun 20, 2023
| @@ -188,6 +192,9 @@ func (ro ReadOptions) merge(opts ReadOptions) ReadOptions { | |||
| if opts.RequestTag != "" { | |||
| merged.RequestTag = opts.RequestTag | |||
| } | |||
| if opts.DataBoostEnabled { | |||
There was a problem hiding this comment.
Hmmm.... This means that you cannot override a false value in ro. I guess that is OK, as we don't allow 'unsetting' any of the other values through this method either. (No action needed, just thinking out loud....)
rahul2393
approved these changes
Jun 20, 2023
gauravpurohit06
approved these changes
Jun 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support for databoost enabled in PartitionedRead and PartitionedQuery