-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(analytics/admin): update the ReportingAttributionModel
enum to rename CROSS_CHANNEL_DATA_DRIVEN
to PAID_AND_ORGANIC_CHANNELS_DATA_DRIVEN
, CROSS_CHANNEL_LAST_CLICK
to PAID_AND_ORGANIC_CHANNELS_LAST_CLICK
, CROSS_CHANNEL_FIRST_CLICK
to `...
#8330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ANNEL_DATA_DRIVEN` to `PAID_AND_ORGANIC_CHANNELS_DATA_DRIVEN`, `CROSS_CHANNEL_LAST_CLICK` to `PAID_AND_ORGANIC_CHANNELS_LAST_CLICK`, `CROSS_CHANNEL_FIRST_CLICK` to `PAID_AND_ORGANIC_CHANNELS_FIRST_CLICK`, `CROSS_CHANNEL_LINEAR` to `PAID_AND_ORGANIC_CHANNELS_LINEAR`, `CROSS_CHANNEL_POSITION_BASED` to `PAID_AND_ORGANIC_CHANNELS_POSITION_BASED` `CROSS_CHANNEL_TIME_DECAY` to `PAID_AND_ORGANIC_CHANNELS_TIME_DECAY`, `ADS_PREFERRED_LAST_CLICK` to `GOOGLE_PAID_CHANNELS_LAST_CLICK` fix!: update the `AdsWebConversionDataExportScope` enum to rename `CROSS_CHANNEL` to `PAID_AND_ORGANIC_CHANNELS`, `ADS_PREFERRED` to `GOOGLE_PAID_CHANNELS` PiperOrigin-RevId: 551280325 Source-Link: googleapis/googleapis@0d84384 Source-Link: googleapis/googleapis-gen@da9de65 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZGE5ZGU2NTgzNGE0YjZiN2VjNDU4NjIyMDUwMGU4Y2VmZWI1ZWZkMyJ9
f2dec50
to
711d31f
Compare
ReportingAttributionModel
enum to rename CROSS_CHANNEL_DATA_DRIVEN
to PAID_AND_ORGANIC_CHANNELS_DATA_DRIVEN
, CROSS_CHANNEL_LAST_CLICK
to PAID_AND_ORGANIC_CHANNELS_LAST_CLICK
, CROSS_CHANNEL_FIRST_CLICK
to `PAID_AND_ORGANIC_C...ReportingAttributionModel
enum to rename CROSS_CHANNEL_DATA_DRIVEN
to PAID_AND_ORGANIC_CHANNELS_DATA_DRIVEN
, CROSS_CHANNEL_LAST_CLICK
to PAID_AND_ORGANIC_CHANNELS_LAST_CLICK
, CROSS_CHANNEL_FIRST_CLICK
to `...
ReportingAttributionModel
enum to rename CROSS_CHANNEL_DATA_DRIVEN
to PAID_AND_ORGANIC_CHANNELS_DATA_DRIVEN
, CROSS_CHANNEL_LAST_CLICK
to PAID_AND_ORGANIC_CHANNELS_LAST_CLICK
, CROSS_CHANNEL_FIRST_CLICK
to `...ReportingAttributionModel
enum to rename CROSS_CHANNEL_DATA_DRIVEN
to PAID_AND_ORGANIC_CHANNELS_DATA_DRIVEN
, CROSS_CHANNEL_LAST_CLICK
to PAID_AND_ORGANIC_CHANNELS_LAST_CLICK
, CROSS_CHANNEL_FIRST_CLICK
to `...
Breaking change in analytics v1alpha was accepted as its an alpha channel and users were notififed ahead of time. |
quartzmo
approved these changes
Jul 27, 2023
Merged
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Jul 27, 2023
🤖 I have created a release *beep* *boop* --- <details><summary>analytics: 0.21.3</summary> ## [0.21.3](https://togithub.com/googleapis/google-cloud-go/compare/analytics/v0.21.2...analytics/v0.21.3) (2023-07-27) ### Bug Fixes * **analytics/admin:** Update the `ReportingAttributionModel` enum to rename `CROSS_CHANNEL_DATA_DRIVEN` to `PAID_AND_ORGANIC_CHANNELS_DATA_DRIVEN`, `CROSS_CHANNEL_LAST_CLICK` to `PAID_AND_ORGANIC_CHANNELS_LAST_CLICK`, `CROSS_CHANNEL_FIRST_CLICK` to `... ([#8330](https://togithub.com/googleapis/google-cloud-go/issues/8330)) ([f7939e0](https://togithub.com/googleapis/google-cloud-go/commit/f7939e093159a40d8be0ca4a60284b5bad524ae5)) </details> --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PAID_AND_ORGANIC_C...
HANNELS_FIRST_CLICK
CROSS_CHANNEL_TIME_DECAY
,
CROSS_CHANNEL_LINEARto
PAID_AND_ORGANIC_CHANNELS_LINEAR,
CROSS_CHANNEL_POSITION_BASEDto
PAID_AND_ORGANIC_CHANNELS_POSITION_BASEDto
PAID_AND_ORGANIC_CHANNELS_TIME_DECAY,
ADS_PREFERRED_LAST_CLICKto
GOOGLE_PAID_CHANNELS_LAST_CLICK`fix: update the
AdsWebConversionDataExportScope
enum to renameCROSS_CHANNEL
toPAID_AND_ORGANIC_CHANNELS
,ADS_PREFERRED
toGOOGLE_PAID_CHANNELS
PiperOrigin-RevId: 551280325
Source-Link: googleapis/googleapis@0d84384
Source-Link: https://github.com/googleapis/googleapis-gen/commit/da9de65834a4b6b7ec4586220500e8cefeb5efd3
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZGE5ZGU2NTgzNGE0YjZiN2VjNDU4NjIyMDUwMGU4Y2VmZWI1ZWZkMyJ9