Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(analytics/admin): update the ReportingAttributionModel enum to rename CROSS_CHANNEL_DATA_DRIVEN to PAID_AND_ORGANIC_CHANNELS_DATA_DRIVEN, CROSS_CHANNEL_LAST_CLICK to PAID_AND_ORGANIC_CHANNELS_LAST_CLICK, CROSS_CHANNEL_FIRST_CLICK to `... #8330

Merged
merged 4 commits into from
Jul 27, 2023

Conversation

gcf-owl-bot[bot]
Copy link
Contributor

@gcf-owl-bot gcf-owl-bot bot commented Jul 26, 2023

PAID_AND_ORGANIC_C...

  • Regenerate this pull request now.

HANNELS_FIRST_CLICK, CROSS_CHANNEL_LINEARtoPAID_AND_ORGANIC_CHANNELS_LINEAR, CROSS_CHANNEL_POSITION_BASEDtoPAID_AND_ORGANIC_CHANNELS_POSITION_BASED CROSS_CHANNEL_TIME_DECAYtoPAID_AND_ORGANIC_CHANNELS_TIME_DECAY, ADS_PREFERRED_LAST_CLICKtoGOOGLE_PAID_CHANNELS_LAST_CLICK`

fix: update the AdsWebConversionDataExportScope enum to rename CROSS_CHANNEL to PAID_AND_ORGANIC_CHANNELS, ADS_PREFERRED to GOOGLE_PAID_CHANNELS

PiperOrigin-RevId: 551280325

Source-Link: googleapis/googleapis@0d84384

Source-Link: https://github.com/googleapis/googleapis-gen/commit/da9de65834a4b6b7ec4586220500e8cefeb5efd3
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZGE5ZGU2NTgzNGE0YjZiN2VjNDU4NjIyMDUwMGU4Y2VmZWI1ZWZkMyJ9

…ANNEL_DATA_DRIVEN` to `PAID_AND_ORGANIC_CHANNELS_DATA_DRIVEN`, `CROSS_CHANNEL_LAST_CLICK` to `PAID_AND_ORGANIC_CHANNELS_LAST_CLICK`, `CROSS_CHANNEL_FIRST_CLICK` to `PAID_AND_ORGANIC_CHANNELS_FIRST_CLICK`, `CROSS_CHANNEL_LINEAR` to `PAID_AND_ORGANIC_CHANNELS_LINEAR`, `CROSS_CHANNEL_POSITION_BASED` to `PAID_AND_ORGANIC_CHANNELS_POSITION_BASED` `CROSS_CHANNEL_TIME_DECAY` to `PAID_AND_ORGANIC_CHANNELS_TIME_DECAY`, `ADS_PREFERRED_LAST_CLICK` to `GOOGLE_PAID_CHANNELS_LAST_CLICK`

fix!: update the `AdsWebConversionDataExportScope` enum to rename `CROSS_CHANNEL` to `PAID_AND_ORGANIC_CHANNELS`, `ADS_PREFERRED` to `GOOGLE_PAID_CHANNELS`

PiperOrigin-RevId: 551280325

Source-Link: googleapis/googleapis@0d84384

Source-Link: googleapis/googleapis-gen@da9de65
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZGE5ZGU2NTgzNGE0YjZiN2VjNDU4NjIyMDUwMGU4Y2VmZWI1ZWZkMyJ9
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jul 26, 2023
@product-auto-label product-auto-label bot added the size: l Pull request size is large. label Jul 26, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 26, 2023
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 26, 2023
@gcf-owl-bot gcf-owl-bot bot changed the title fix!: update the ReportingAttributionModel enum to rename CROSS_CHANNEL_DATA_DRIVEN to PAID_AND_ORGANIC_CHANNELS_DATA_DRIVEN, CROSS_CHANNEL_LAST_CLICK to PAID_AND_ORGANIC_CHANNELS_LAST_CLICK, CROSS_CHANNEL_FIRST_CLICK to `PAID_AND_ORGANIC_C... fix!(analytics/admin)!: update the ReportingAttributionModel enum to rename CROSS_CHANNEL_DATA_DRIVEN to PAID_AND_ORGANIC_CHANNELS_DATA_DRIVEN, CROSS_CHANNEL_LAST_CLICK to PAID_AND_ORGANIC_CHANNELS_LAST_CLICK, CROSS_CHANNEL_FIRST_CLICK to `... Jul 26, 2023
@gcf-owl-bot gcf-owl-bot bot marked this pull request as ready for review July 26, 2023 21:57
@gcf-owl-bot gcf-owl-bot bot requested review from a team, shollyman and bhshkh as code owners July 26, 2023 21:57
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jul 26, 2023
@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. and removed size: l Pull request size is large. labels Jul 26, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 26, 2023
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 26, 2023
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jul 26, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 26, 2023
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 26, 2023
@codyoss codyoss changed the title fix!(analytics/admin)!: update the ReportingAttributionModel enum to rename CROSS_CHANNEL_DATA_DRIVEN to PAID_AND_ORGANIC_CHANNELS_DATA_DRIVEN, CROSS_CHANNEL_LAST_CLICK to PAID_AND_ORGANIC_CHANNELS_LAST_CLICK, CROSS_CHANNEL_FIRST_CLICK to `... fix(analytics/admin): update the ReportingAttributionModel enum to rename CROSS_CHANNEL_DATA_DRIVEN to PAID_AND_ORGANIC_CHANNELS_DATA_DRIVEN, CROSS_CHANNEL_LAST_CLICK to PAID_AND_ORGANIC_CHANNELS_LAST_CLICK, CROSS_CHANNEL_FIRST_CLICK to `... Jul 27, 2023
@noahdietz
Copy link
Contributor

Breaking change in analytics v1alpha was accepted as its an alpha channel and users were notififed ahead of time.

@noahdietz noahdietz added breaking change allowed automerge Merge the pull request once unit tests and other checks pass. labels Jul 27, 2023
@noahdietz noahdietz removed the automerge Merge the pull request once unit tests and other checks pass. label Jul 27, 2023
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jul 27, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 27, 2023
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 27, 2023
@noahdietz noahdietz added the automerge Merge the pull request once unit tests and other checks pass. label Jul 27, 2023
@gcf-merge-on-green gcf-merge-on-green bot merged commit f7939e0 into main Jul 27, 2023
8 of 9 checks passed
@gcf-merge-on-green gcf-merge-on-green bot deleted the owl-bot-copy branch July 27, 2023 17:40
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jul 27, 2023
@release-please release-please bot mentioned this pull request Jul 27, 2023
gcf-merge-on-green bot pushed a commit that referenced this pull request Jul 27, 2023
🤖 I have created a release *beep* *boop*
---


<details><summary>analytics: 0.21.3</summary>

## [0.21.3](https://togithub.com/googleapis/google-cloud-go/compare/analytics/v0.21.2...analytics/v0.21.3) (2023-07-27)


### Bug Fixes

* **analytics/admin:** Update the `ReportingAttributionModel` enum to rename `CROSS_CHANNEL_DATA_DRIVEN` to `PAID_AND_ORGANIC_CHANNELS_DATA_DRIVEN`, `CROSS_CHANNEL_LAST_CLICK` to `PAID_AND_ORGANIC_CHANNELS_LAST_CLICK`, `CROSS_CHANNEL_FIRST_CLICK` to `... ([#8330](https://togithub.com/googleapis/google-cloud-go/issues/8330)) ([f7939e0](https://togithub.com/googleapis/google-cloud-go/commit/f7939e093159a40d8be0ca4a60284b5bad524ae5))
</details>

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants