Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bigquery: breaking changes for v2 #836

Closed
jba opened this issue Dec 22, 2017 · 4 comments
Closed

bigquery: breaking changes for v2 #836

jba opened this issue Dec 22, 2017 · 4 comments
Assignees
Labels
api: bigquery Issues related to the BigQuery API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@jba
Copy link
Contributor

jba commented Dec 22, 2017

Consider these breaking changes for v2 of the client:

  • Rename FullyQualifiedName to FullyQualifiedID.
  • Instead of LoaderFrom, a LoadFrom method that takes a LoadConfig. Similarly for CopierFrom and ExtractorTo.
  • Rethink how external tables and data are specified. GCSReference should not have to implement ExternalData for backwards compatibility.
  • Rethink load sources. Now LoadSource is implemented by ReaderSource and GCSReference. Is there a clearer design?
  • Rename the QueryConfig.Q field.
  • Rethink the loader/saver design, especially the names ValueSaver and ValuesSaver.
@jba jba added api: bigquery Issues related to the BigQuery API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels Dec 22, 2017
@jba jba self-assigned this Dec 22, 2017
@jba
Copy link
Contributor Author

jba commented Dec 28, 2017

@kurtmaile
Copy link

Agreed would be nice.

@JustinBeckwith JustinBeckwith added the 🚨 This issue needs some love. label Jun 20, 2018
@jba jba removed the priority: p2 Moderately-important priority. Fix may not be included in next release. label Jul 20, 2018
@JustinBeckwith JustinBeckwith removed the 🚨 This issue needs some love. label Jul 20, 2018
@jeanbza jeanbza unassigned jba Oct 19, 2018
@jeanbza
Copy link
Member

jeanbza commented Jun 11, 2019

Tracking in internal bug 135054263.

@jeanbza jeanbza closed this as completed Jun 11, 2019
@derekperkins
Copy link
Contributor

The Inserter interface leaves a lot to be desired. I'd much prefer to have an option to pass in json that I've marshaled rather than having to jump through hoops to get map[string]bigquery.Value. We have some complex structs where we double marshal to get data into that format.

func (o *ComplexBQObject) Save() (map[string]bigquery.Value, string, error) {
	data, err := json.Marshal(o)
	if err != nil {
		return nil, "", e.Wrap(err)
	}
	toSave := map[string]bigquery.Value{}
	if err = json.Unmarshal(data, &toSave); err != nil {
		return nil, "", e.Wrap(err)
	}
	return toSave, "", nil
}

gcf-owl-bot bot added a commit that referenced this issue Jul 25, 2023
Source-Link: googleapis/googleapis@e8c26cc

Source-Link: googleapis/googleapis-gen@81d1ed1
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiODFkMWVkMTE3ZjY4NDRmZWZiMjM5ZTBjZDA4NGJhMTAxODQ2ZWYwMSJ9
gcf-merge-on-green bot pushed a commit that referenced this issue Jul 25, 2023
… to v1beta3 public (#8323)

- [ ] Regenerate this pull request now.

PiperOrigin-RevId: 550912849

Source-Link: https://togithub.com/googleapis/googleapis/commit/b75339be89a5ae835d478bd5490b4a71df55e085

Source-Link: https://togithub.com/googleapis/googleapis-gen/commit/c196282784068f8bc31d6d7667416fddeb297dbf
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYzE5NjI4Mjc4NDA2OGY4YmMzMWQ2ZDc2Njc0MTZmZGRlYjI5N2RiZiJ9
BEGIN_NESTED_COMMIT
feat(compute): Update Compute Engine API to revision 20230711 (#836)
Source-Link: https://togithub.com/googleapis/googleapis/commit/e8c26cc311b6bc6aa097516bac60c79dd0ebf623

Source-Link: https://togithub.com/googleapis/googleapis-gen/commit/81d1ed117f6844fefb239e0cd084ba101846ef01
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiODFkMWVkMTE3ZjY4NDRmZWZiMjM5ZTBjZDA4NGJhMTAxODQ2ZWYwMSJ9
END_NESTED_COMMIT
gcf-merge-on-green bot pushed a commit that referenced this issue Jul 26, 2023
🤖 I have created a release *beep* *boop*
---


<details><summary>aiplatform: 1.47.0</summary>

## [1.47.0](https://togithub.com/googleapis/google-cloud-go/compare/aiplatform/v1.46.0...aiplatform/v1.47.0) (2023-07-26)


### Features

* **aiplatform:** ScheduleService (schedule_service.proto) creates and manages Schedule resources to launch scheduled pipelines runs ([7cb7f66](https://togithub.com/googleapis/google-cloud-go/commit/7cb7f66f0646617c27aa9a9b4fe38b9f368eb3bb))
</details>

<details><summary>cloudbuild: 1.13.0</summary>

## [1.13.0](https://togithub.com/googleapis/google-cloud-go/compare/cloudbuild/v1.12.0...cloudbuild/v1.13.0) (2023-07-26)


### Features

* **cloudbuild/apiv1:** Add automap_substitutions flag to use substitutions as envs in Cloud Build ([327e101](https://togithub.com/googleapis/google-cloud-go/commit/327e10188a2e22dd7b7e6c12a8cf66729f65974c))
* **cloudbuild/apiv1:** Add git_file_source and git_repo_source to build_trigger ([7cb7f66](https://togithub.com/googleapis/google-cloud-go/commit/7cb7f66f0646617c27aa9a9b4fe38b9f368eb3bb))
</details>

<details><summary>cloudtasks: 1.12.1</summary>

## [1.12.1](https://togithub.com/googleapis/google-cloud-go/compare/cloudtasks/v1.12.0...cloudtasks/v1.12.1) (2023-07-26)


### Documentation

* **cloudtasks:** Minor formatting ([cdee2d9](https://togithub.com/googleapis/google-cloud-go/commit/cdee2d918015c9b0a53aa8283085214d9a11c77c))
</details>

<details><summary>commerce: 0.1.0</summary>

## 0.1.0 (2023-07-26)


### Features

* **commerce/consumer/procurement:** Consumer Procurement API v1 ([#8327](https://togithub.com/googleapis/google-cloud-go/issues/8327)) ([327e101](https://togithub.com/googleapis/google-cloud-go/commit/327e10188a2e22dd7b7e6c12a8cf66729f65974c))
* **commerce:** Start generating apiv1 ([#8322](https://togithub.com/googleapis/google-cloud-go/issues/8322)) ([db4f48b](https://togithub.com/googleapis/google-cloud-go/commit/db4f48bc9d5366f524f1fce82f2fea8094ea8c1e))
</details>

<details><summary>compute: 1.23.0</summary>

## [1.23.0](https://togithub.com/googleapis/google-cloud-go/compare/compute/v1.22.0...compute/v1.23.0) (2023-07-26)


### Features

* **compute:** Update Compute Engine API to revision 20230711 ([#836](https://togithub.com/googleapis/google-cloud-go/issues/836)) ([08b151a](https://togithub.com/googleapis/google-cloud-go/commit/08b151a3fd9b614b6696e99d065ecda339ed00ff))
</details>

<details><summary>confidentialcomputing: 1.1.0</summary>

## [1.1.0](https://togithub.com/googleapis/google-cloud-go/compare/confidentialcomputing/v1.0.0...confidentialcomputing/v1.1.0) (2023-07-26)


### Features

* **confidentialcomputing:** Added support for signed container image and custom audience and nonce requests ([327e101](https://togithub.com/googleapis/google-cloud-go/commit/327e10188a2e22dd7b7e6c12a8cf66729f65974c))
</details>

<details><summary>dataplex: 1.9.0</summary>

## [1.9.0](https://togithub.com/googleapis/google-cloud-go/compare/dataplex/v1.8.1...dataplex/v1.9.0) (2023-07-26)


### Features

* **dataplex:** New service DataTaxonomyService and related messages ([#8320](https://togithub.com/googleapis/google-cloud-go/issues/8320)) ([cdee2d9](https://togithub.com/googleapis/google-cloud-go/commit/cdee2d918015c9b0a53aa8283085214d9a11c77c))
</details>

<details><summary>datastream: 1.10.0</summary>

## [1.10.0](https://togithub.com/googleapis/google-cloud-go/compare/datastream/v1.9.1...datastream/v1.10.0) (2023-07-26)


### Features

* **datastream:** Add precision and scale to MysqlColumn ([7cb7f66](https://togithub.com/googleapis/google-cloud-go/commit/7cb7f66f0646617c27aa9a9b4fe38b9f368eb3bb))
</details>

<details><summary>documentai: 1.22.0</summary>

## [1.22.0](https://togithub.com/googleapis/google-cloud-go/compare/documentai/v1.21.0...documentai/v1.22.0) (2023-07-26)


### Features

* **documentai:** Exposed Import PV external_processor_version_source to v1beta3 public ([#8323](https://togithub.com/googleapis/google-cloud-go/issues/8323)) ([08b151a](https://togithub.com/googleapis/google-cloud-go/commit/08b151a3fd9b614b6696e99d065ecda339ed00ff))
</details>

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the BigQuery API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

No branches or pull requests

5 participants