feat(auth): add detect package #8491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The purpose of this package is to source credentials via ADC. It is analogous to the oauth2/google package but is more limited, currently. It does not provide helper constructors for creating things like a compute credential and instead has a single constructor that does it all. Because of this it is more has more extensible options. Purposefully missing from this package is support for external accounts, but some documentation is there. This will come up in a seperate PR as that has a lot of extra code to review and I tried to shrink the size of this commit as much as possible. There are some TODOs in this commit that will be cleaned up in a future commit that requires more refactoring.
|
apidiff error: |
|
@quartzmo on purpose, noticed this was missed from the last PR were we said to stop using the word config and consistently use options |
noahdietz
reviewed
Aug 28, 2023
noahdietz
approved these changes
Aug 28, 2023
quartzmo
reviewed
Aug 28, 2023
quartzmo
reviewed
Aug 28, 2023
quartzmo
reviewed
Aug 29, 2023
quartzmo
reviewed
Aug 29, 2023
quartzmo
approved these changes
Aug 29, 2023
This was referenced Aug 29, 2023
Merged
codyoss
added a commit
to codyoss/google-cloud-go
that referenced
this pull request
Aug 29, 2023
This is a direct followup to googleapis#8491 and adds the last part of the detect package; external account support.
codyoss
added a commit
that referenced
this pull request
Sep 6, 2023
This is a direct follow up to #8491 and adds the last part of the detect package; external account support.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this package is to source credentials via ADC. It is analogous to the oauth2/google package but is more limited, currently. It does not provide helper constructors for creating things like a compute credential and instead has a single constructor that does it all. Because of this it is more has more extensible options.
Purposefully missing from this package is support for external accounts, but some documentation is there. This will come up in a seperate PR as that has a lot of extra code to review and I tried to shrink the size of this commit as much as possible.
There are some TODOs in this commit that will be cleaned up in a future commit that requires more refactoring.